Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add continuous integration/circleci #39

Conversation

doublethefish
Copy link

This adds CircleCI auto-test and running of the examples to node-red-node-test-helper.

Example of it running against my repo:
https://circleci.com/gh/doublethefish/node-red-node-test-helper

In addition to the great benefits of using CI, part of the intent here is to demonstrate how to run the tests and examples, bolstering the pretty good documentation.

We use circle because it is very simple to setup and took less than 20
mins to implement and test.

Here we use a rolling docker image for node.js, so we get constantly
test against latest. At some point it may be prudent to schedule a build
so we can disambiguate between code-fails and node upgrade fails.
Although this step is clearly listed in the docs, this caught me out
when running through the examples because, at the time of writing,
non-0.18.0/0.20.0 are the only versions that appear to work with this
framework, not latest. Whilst it is clearly expressed as an npm
peerDependency and using the most recent version of node-red does print
errors about this, new people to the framework may be put off by this -
as it *appear* that it doesn't work out-of-the-box.

Part of the reason for this PR is to demonstrate how to use these tools.
@jsf-clabot
Copy link

jsf-clabot commented Nov 2, 2019

CLA assistant check
All committers have signed the CLA.

@doublethefish
Copy link
Author

Can I get an update on this? Or should I just close it?

@knolleary
Copy link
Member

Hi, sorry to have overlooked this for so long.

We use Travis in the main project repository. Not keen to introduce another 3rd party service as a dependency for us to have to maintain.

@doublethefish
Copy link
Author

Grand, thanks for the update. I shall close and log an issue to get a badge added to the main repo.

@doublethefish
Copy link
Author

doublethefish commented Aug 10, 2020

Ah, I misunderstood your reply. I was going through my history, according to #7 you have travis in the main repo, which is not this one.

So would you be amiable to having a travis setup on this repo?

I want to see that the system is green, and know how to test it, before contributing.

@knolleary
Copy link
Member

Yup, a Travis setup would be welcome.

@doublethefish
Copy link
Author

Just a quick update whilst I try to find time to look at this again. When I ran travis against this repo a few days back it failed.

I cloned the main repo's travis config, but I've not yet done any due diligence (or any other work) on whether its my changes or the repo that's at fault. But you can have a look in the mean-time:
https://travis-ci.org/github/doublethefish/node-red-node-test-helper

p.s. the main repo seems to be failing which would be nice to see fixed https://travis-ci.org/github/node-red/node-red/jobs/718826913

@knolleary
Copy link
Member

Thanks for the update.

We're well aware of the Travis status of the main repo and the activity going on to resolve that.

@knolleary knolleary closed this Jun 21, 2022
@doublethefish doublethefish deleted the feature/add_continuous_integration/circleci branch June 29, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants