-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved search for response nodes #64
Conversation
…hen checking for response nodes
You seem to have added a load of unnecessary white space changes that makes it very hard to see what the actual changes are. Please revert them and update the PR. Thanks |
Hi, thanks for the module. The more I’ve used it the more I’ve thought about investing some effort into it beyond that small hack. Have you looked at what might be involved in implementing openapi 3.0? Is that something anyone is currently working on?
Regards
Guy
On 5 Mar 2019, at 9:42 pm, Dave Conway-Jones <[email protected]<mailto:[email protected]>> wrote:
You seem to have added a load of unnecessary white space changes that makes it very hard to see what the actual changes are. Please revert them and update the PR.
Also please don't change the source url in package.json.
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#64 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AtV5z7VoLHy82JJ1Jh7jD6TapZ01C-suks5vTkn3gaJpZM4bYDu6>.
|
I'd be happy to collaborate on such a quest, @guy-datacom. There are lots of discussion points regarding a move to OpenAPI 3.0. Lots of breaking changes to code, and there's now a React-based branch replacing the backbone.js one. It looks like there are even competitor libraries that produce OpenAPI compatible definitions. For now I've done some work to get rid of problematic contributed commits, restore the core functionality without the introduced bugs, and modernise the code. |
Resolved by #67 |
checkWiresForHttpResponse() does not currently look beyond the first wire when checking for response nodes. My flows have many multi-output function nodes that meant this module didn't find the response nodes. This change fixes that, and does not seem to have any other consequences.