Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved search for response nodes #64

Closed
wants to merge 15 commits into from

Conversation

guy-datacom
Copy link

checkWiresForHttpResponse() does not currently look beyond the first wire when checking for response nodes. My flows have many multi-output function nodes that meant this module didn't find the response nodes. This change fixes that, and does not seem to have any other consequences.

@jsf-clabot
Copy link

jsf-clabot commented Mar 1, 2019

CLA assistant check
All committers have signed the CLA.

@dceejay
Copy link
Member

dceejay commented Mar 5, 2019

You seem to have added a load of unnecessary white space changes that makes it very hard to see what the actual changes are. Please revert them and update the PR.
Also please don't change the source url in package.json.

Thanks

@guy-datacom
Copy link
Author

guy-datacom commented Mar 5, 2019 via email

@JonSilver
Copy link
Contributor

Have you looked at what might be involved in implementing openapi 3.0? Is that something anyone is currently working on?

I'd be happy to collaborate on such a quest, @guy-datacom. There are lots of discussion points regarding a move to OpenAPI 3.0. Lots of breaking changes to code, and there's now a React-based branch replacing the backbone.js one. It looks like there are even competitor libraries that produce OpenAPI compatible definitions.

For now I've done some work to get rid of problematic contributed commits, restore the core functionality without the introduced bugs, and modernise the code.

@knolleary
Copy link
Member

Resolved by #67

@knolleary knolleary closed this Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants