[for review] squash branch diff #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix optimims port to bsc
fix basefee
fix gasprice
Cherry pick ci with tag
update to for_bsc 0.5
feat(.github): add docker-build-push.yml
average base fee
nolanxyg
commented
Apr 26, 2023
| @@ -431,6 +476,9 @@ func (m *SimpleTxManager) suggestGasPriceCaps(ctx context.Context) (*big.Int, *b | |||
| m.metr.RPCError() | |||
| return nil, nil, fmt.Errorf("failed to fetch the suggested basefee: %w", err) | |||
| } else if head.BaseFee == nil { | |||
There was a problem hiding this comment.
all bsc block head.BaseFee is nil, right?
op-node/node/node.go
Outdated
| cfg.L1EpochPollInterval, time.Second*10) | ||
| n.l1FinalizedSub = eth.PollBlockChanges(n.resourcesCtx, n.log, n.l1Source, n.OnNewL1Finalized, eth.Finalized, | ||
| n.l1FinalizedSub = eth.PollBlockChanges(n.resourcesCtx, n.log, n.l1Source, n.OnNewL1Finalized, eth.Unsafe, |
There was a problem hiding this comment.
what's the response of bsc rpc when passing eth.Unsafe tag?
Comment on lines
+138
to
+140
| if opservice.ForBSC { | ||
| infoDat.BaseFee = BSCFakeBaseFee | ||
| } |
There was a problem hiding this comment.
will it in-consist with func (ba *FetchingAttributesBuilder) prepareAverageGasPrice(ctx context.Context, epoch eth.BlockID) (*big.Int, error)?
| @@ -152,7 +152,8 @@ abstract contract ResourceMetering is Initializable { | |||
| // division by zero for L1s that don't support 1559 or to avoid excessive gas burns during | |||
| // periods of extremely low L1 demand. One-day average gas fee hasn't dipped below 1 gwei | |||
| // during any 1 day period in the last 5 years, so should be fine. | |||
| uint256 gasCost = resourceCost / Math.max(block.basefee, 1 gwei); | |||
| // uint256 gasCost = resourceCost / Math.max(block.basefee, 1 gwei); | |||
| uint256 gasCost = resourceCost / 5 gwei; | |||
feat: add API admin_sequencerStopped
commit 6695f82 Merge: e07e80c a582e6f Author: Kero <[email protected]> Date: Wed Apr 19 14:25:18 2023 +0800 Merge pull request #17 from node-real/gastrack average base fee commit e07e80c Merge: 250fbcb 372ec73 Author: Kero <[email protected]> Date: Mon Apr 17 18:29:41 2023 +0800 Merge pull request #14 from keroro520/docker-build-push-workflow feat(.github): add docker-build-push.yml commit 372ec73 Author: keroro <[email protected]> Date: Tue Apr 11 10:22:14 2023 +0800 feat(.github): add docker-build-push.yml commit 250fbcb Merge: f7e1641 8fa4ea6 Author: Kero <[email protected]> Date: Thu Apr 13 15:49:56 2023 +0800 Merge pull request #11 from node-real/update_to_for_bsc_0.5 update to for_bsc 0.5 commit 8fa4ea6 Author: s7v7nislands <[email protected]> Date: Thu Apr 13 13:22:43 2023 +0800 update to for_bsc 0.5 commit a582e6f Author: s7v7nislands <[email protected]> Date: Wed Apr 12 18:24:56 2023 +0800 filter system trxs which gas price is zero commit f7e1641 Merge: 0188575 25954a2 Author: Kero <[email protected]> Date: Wed Apr 12 15:29:02 2023 +0800 Merge pull request #9 from keroro520/cherry-pick-ci-with-tag Cherry pick ci with tag commit 25954a2 Author: keroro <[email protected]> Date: Tue Apr 11 21:15:56 2023 +0800 fix(.github): change create trigger to push trigger commit 4173294 Author: ArthurMa <[email protected]> Date: Tue Apr 11 19:30:23 2023 +0800 Update ci-with-tag.yml commit a7672a5 Author: ArthurMa <[email protected]> Date: Tue Apr 11 18:44:26 2023 +0800 Update ci-with-tag.yml commit 071c9d8 Author: ArthurMa <[email protected]> Date: Tue Apr 11 17:51:44 2023 +0800 Update ci-with-tag.yml commit 1d83273 Author: ArthurMa <[email protected]> Date: Tue Apr 11 17:44:58 2023 +0800 Update ci-with-tag.yml commit 023aa14 Author: ArthurMa <[email protected]> Date: Tue Apr 11 17:12:30 2023 +0800 Update ci-with-tag.yml commit 40a7234 Author: ArthurMa <[email protected]> Date: Tue Apr 11 17:10:56 2023 +0800 Update and rename ci-with-pr.yml to ci-with-tag.yml commit 2f7128c Author: arthurma <[email protected]> Date: Tue Apr 11 14:24:56 2023 +0800 [beta] new a CI flow to export image to nr ecr commit 307353a Author: s7v7nislands <[email protected]> Date: Mon Apr 10 16:16:52 2023 +0800 add avarage gasprice to l1 block info commit 0188575 Merge: 9b95617 2bf1e92 Author: s7v7nislands <[email protected]> Date: Thu Apr 6 17:59:17 2023 +0800 Merge pull request #4 from node-real/fix_gasprice fix gasprice commit 2bf1e92 Author: s7v7nislands <[email protected]> Date: Thu Apr 6 16:47:03 2023 +0800 fix gasprice commit 9b95617 Merge: fbba7ba d75fb80 Author: Kero <[email protected]> Date: Tue Mar 28 16:53:01 2023 +0800 Merge pull request #2 from node-real/fix_basefee fix basefee commit d75fb80 Author: s7v7nislands <[email protected]> Date: Tue Mar 28 16:51:12 2023 +0800 fix basefee commit fbba7ba Merge: 7bdcb0f 22779e4 Author: s7v7nislands <[email protected]> Date: Mon Mar 27 16:19:31 2023 +0800 Merge pull request #1 from node-real/fix_bsc fix optimims port to bsc commit 22779e4 Author: s7v7nislands <[email protected]> Date: Sun Mar 26 21:44:48 2023 +0800 fix optimims port to bsc fix trx manager feat: add API admin_sequencerStopped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.