Add SPC5 to generic config updater file #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenxs
reviewed
Jul 18, 2024
| @@ -20,9 +20,12 @@ | |||
| "spc1": [ "ACS-MSN2700", "ACS-MSN2740", "ACS-MSN2100", "ACS-MSN2410", "ACS-MSN2010", "Mellanox-SN2700", "Mellanox-SN2700-C28D8", "Mellanox-SN2700-D40C8S8", "Mellanox-SN2700-D44C10", "Mellanox-SN2700-D48C8", | |||
| "ACS-MSN2700-A1", "Mellanox-SN2700-A1", "Mellanox-SN2700-A1-C28D8", "Mellanox-SN2700-A1-D40C8S8", "Mellanox-SN2700-A1-D44C10", "Mellanox-SN2700-A1-D48C8" ], | |||
| "spc2": [ "ACS-MSN3800", "Mellanox-SN3800-D112C8", "ACS-MSN3420", "ACS-MSN3700C", "ACS-MSN3700", "Mellanox-SN3800-C64", "Mellanox-SN3800-D100C12S2", "Mellanox-SN3800-D24C52", "Mellanox-SN3800-D28C49S1", "Mellanox-SN3800-D28C50" ], | |||
| "spc3": [ "ACS-MSN4700", "ACS-MSN4600", "ACS-MSN4600C", "ACS-MSN4410", "ACS-SN4280", "Mellanox-SN4600C-D112C8", "Mellanox-SN4600C-C64", "Mellanox-SN4700-O8C48", "Mellanox-SN4600C-D100C12S2", "Mellanox-SN4600C-D48C40", | |||
There was a problem hiding this comment.
ACS-SN4280 is removed. by mistake?
the rest LGTM
noaOrMlnx
force-pushed
the
gen_cfg_update_add_spc5
branch
from
2d5cd95 to
d7d4e94
Compare
stephenxs
approved these changes
Jul 18, 2024
…et#3417) #### What I did 1. Enable "show ip bgp" on sup and "-n all" for show ip bgp network. 2. Modify README.doc to make the instructions of building and installing the wheel package more clear. 3. Improve the output format of rexec command #### How I did it Modify the code in show/main.py to enable "show ip bgp ..." on supervisors and modify show/bgp_frr_v4.py to add support for the new features. Update README.md. Modify the rexec implementation to improve the output format. Add unit tests for the above change. #### How to verify it Run on a SONiC chassis
…t memory (sonic-net#3385) Signed-off-by: Mihir Patel <[email protected]>
* Update DB version to 202411 on master branch.
noaOrMlnx
force-pushed
the
gen_cfg_update_add_spc5
branch
from
d7d4e94 to
28c9f38
Compare
What I did Show techsupport is designed to collect logs and core files since given date. I find that some core files are missing when given date is relative, for example "5 minutes ago". Microsoft ADO: 28737486 How I did it Create the reference file at the start of the script, and don't update it in find_files. How to verify it Run end to end test: show_techsupport/test_auto_techsupport.py
#### What I did Added Check for IP Assignment on Port when a Vlan is configured. This PR is created in response to [Issue](sonic-net/sonic-buildimage#19505) #### How I did it Modified config/main.py to add check for IP Assignment when Port has vlan membership #### How to verify it After this, ip cannot be assigned on port which is configured to a VLAN.
* Fixes dropstat multi-asic behaviour by using multi-asic helpers and ensuring that dropstat iterates through correct namespaces when 'show' command is run. Co-authored-by: rdjeric <[email protected]> Co-authored-by: Kenneth Cheung <[email protected]>
* show/bgp_frr_v4.py: change the default behavior of "show ip bgp network" - after change, show ip bgp network will have "all" as the default value of namespace option - after change, ip-address/ip-prefix is a required argument when executing show ip bgp network on a chassis supervisor * tests/remote_show_test.py update unit tests to comply with the new behaviors * tests/show_bgp_network_test.py: update a test vector to make it comply with the new default behavior * tests/bgp_commands_input/bgp_network_test_vector.py: update a test vector to comply with the new default behavior
* Add namespace check for multiasic * Fix format
* Update README.md The new location of the sonic-utilities target wheel package is under bookworm instead of bullseye. Update the README to make it consistent with the current build behavior. * README.md: update build instrucrions
What I did If link local IPv6 address is added as SNMP agent address, it will fail. This PR requires changes in snmpd.conf.j2 template here sonic-net/sonic-buildimage#18350 How I did it Append scope id to ipv6 link local IP address. How to verify it Able to configure link local ipv6 address as snmp agent address sudo config snmpagentaddress add fe80::a%eth0
sonic-net#3450) Signed-off-by: Andriy Yurkiv <[email protected]>
noaOrMlnx
force-pushed
the
gen_cfg_update_add_spc5
branch
from
28c9f38 to
687bfc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add spc5 to generic_config_updater file
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)