Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: pull_request committing on a pull request build trigger doesn't work for doc-and-style #137

Open
k-doering-NOAA opened this issue Aug 2, 2024 · 1 comment
Open

[Bug]: pull_request committing on a pull request build trigger doesn't work for doc-and-style #137

k-doering-NOAA opened this issue Aug 2, 2024 · 1 comment
Assignees
@k-doering-NOAA
Labels
enhancement New feature or request

Comments

@k-doering-NOAA
Copy link
Collaborator

Describe the bug

From @iantaylor-NOAA :

The changes was made after I messed up the workflow by naively having it apply to pull requests (which would have required an extra pull-request to the pull request). See also #135 and discussion here: NOAA-FIMS/FIMS#660.

To Reproduce

  1. Run in an R package:
    ghactions4r::use_doc_and_style_r(how_to_commit = "pull_request", build_trigger = "pull_request")
    and push the workflow to github.

  2. Try creating a branch, make a change that requires styling, and opening a pull request.

  3. The workflow will error

Expected behavior

A pull request opens to the branch.

Another option if we don't want to support this workflow is to have use_doc_and_style_r() error with a helpful message if someone tries to set up a workflow with options how_to_commit = "pull_request", build_trigger = "pull_request"

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which browser are you seeing the problem on?

No response

Which version of ghactions4r are you seeing the problem on?

No response

Additional Context

No response
@k-doering-NOAA k-doering-NOAA added bug Something isn't working triage_needed This issue needs review labels Aug 2, 2024
@k-doering-NOAA k-doering-NOAA self-assigned this Aug 2, 2024
@k-doering-NOAA k-doering-NOAA removed the triage_needed This issue needs review label Aug 2, 2024
@k-doering-NOAA k-doering-NOAA mentioned this issue Aug 2, 2024
Closed
k-doering-NOAA added a commit that referenced this issue Aug 2, 2024
@k-doering-NOAA
add error msg for creating prs on prs in doc and style
37c8dee 
Addresses #137
@k-doering-NOAA k-doering-NOAA mentioned this issue Aug 2, 2024
Merged
k-doering-NOAA added a commit that referenced this issue Aug 2, 2024
@k-doering-NOAA
Doc and style changes (#138)
e567c26 
* add error msg for creating prs on prs in doc and style
Addresses #137

* add doc and style examples
addresses #136

* fix: broken code

* fix: doc mistake
@k-doering-NOAA
Copy link
Collaborator Author

Added an error msg, but lieaving this open in case we actually want to make the option work.

@k-doering-NOAA k-doering-NOAA added enhancement New feature or request and removed bug Something isn't working labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k-doering-NOAA k-doering-NOAA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@k-doering-NOAA