-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: consider having doc-and-style use "commit-directly: true" by default #136
Comments
Thanks for the feedback, @iantaylor-NOAA ! I think this option is included in the
|
Also, I opened #137 for the pull request problem you experienced, thank you for reporting! |
The |
Is your feature request related to a problem? Please describe.
@e-perl-NOAA added
commit-directly: true
to the r4ss workflow for doc-and-style following a suggestion from @k-doering-NOAA and I love it: https://github.com/r4ss/r4ss/blob/spr_split_tables/.github/workflows/call-doc-and-style-r.yml#L21.The changes was made after I messed up the workflow by naively having it apply to pull requests (which would have required an extra pull-request to the pull request). See also #135 and discussion here: NOAA-FIMS/FIMS#660.
Since 2021 I've now merged exactly 100 pull requests created by the doc-and-style workflow in r4ss, and never NOT been happy with the changes. Using
commit-directly: true
avoids all the extra work and notifications associated with merging a pull request while still providing plenty of opportunity to review the changes by looking at the commit that the GHA adds.Describe the solution you would like.
Either add
commit-directly: true
to the workflow or give the user an argument to choose to add it. If there are branch protections, then committing directly to main would be a problem, but in that case everything will come through a pull request and the changes could be committed directly to the branch in the PR.Describe alternatives you have considered
Keep the status-quo workflows and add a note in the documentation that the user could easily make the change manually.
Additional context
No response
The text was updated successfully, but these errors were encountered: