Skip to content

Commit

Permalink
Bump version and changelog for 1.10 release
Browse files Browse the repository at this point in the history
  • Loading branch information
@bonsaiviking
bonsaiviking committed Dec 11, 2020
1 parent 309e7da commit b2c090f
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 3 deletions.
19 changes: 19 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,23 @@

## Npcap 1.10 [2020-12-11]

* Fixed an issue where our upgrade uninstaller would trigger the
[#1924](https://issues.nmap.org/1924) BSoD crash when upgrading from Npcap 0.9988 or older to
version 0.9996 or greater. Fixes [#268](http://issues.npcap.org/268).

* Improved handling of large packets when a very small user buffer size is specified, which could
lead to stalled captures and dropped packets.

* Fix a packet corruption issue when one capture handle sets a snaplen of exactly 256 bytes and
another sets a snaplen of greater than 256 bytes and the packet size exceeds 256 bytes.

* Fix accounting of free space in the kernel buffer so that bugs like the previous one do not cause
space to be permanently lost, leading to dropped packets. Instead, use assertions to catch this
condition in testing with the debug build.

* Check that the npcap driver service is configured for `SYSTEM_START` in the `npcapwatchdog`
scheduled task and correct it if necessary. Windows feature updates can modify this value.

## Npcap 1.00 [2020-09-25]

* After more than 7 years of development and 170 previous public releases, the
Expand Down
6 changes: 3 additions & 3 deletions version.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,11 @@
!define /**/ WINPCAP_MINOR 1
/* WINPCAP_REV should be less than 256 to fit in UCHAR */
#define /*
!define /**/ WINPCAP_REV 0
!define /**/ WINPCAP_REV 10
#define /*
!define /**/ WINPCAP_BUILD 924
!define /**/ WINPCAP_BUILD 1211
#define /*
!define /**/ WINPCAP_VER_STRING "1.00"
!define /**/ WINPCAP_VER_STRING "1.10"
#define /*
!define /**/ NPCAP_SDK_VERSION "1.06"

Expand Down

2 comments on commit b2c090f

@gvanem
Copy link

@gvanem gvanem commented on b2c090f Feb 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using clang-cl -Wall to compile NPcap generates huge amount of warnings. Some are due to this file:

version.h(88,10): warning: '/*' within block comment [-Wcomment]
 !define /**/ WINPCAP_MINOR                             1
         ^
version.h(91,10): warning: '/*' within block comment [-Wcomment]
 !define /**/ WINPCAP_REV                               10
         ^
 ...

What is the purpose of this strange #define syntax?

@dmiller-nmap
Copy link
Contributor

@dmiller-nmap dmiller-nmap commented on b2c090f Mar 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this strange #define syntax?

This makes the file a polyglot header that can be used by MSVC as well as NSIS to build our installer. The C preprocessor ignores as a comment everything between the first /* and the very next */. The NSIS preprocessor treats the # at the beginning of the previous line as introducing a comment, so it does not see the first /*. The next line uses NSIS preprocessor definition syntax, !define, within the C comment. Then the /**/ is recognized by NSIS as an inline comment.

Please sign in to comment.