Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow FormField's error message position to be changed #2561

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

remypar5
Copy link
Contributor

This change doesn't change anything it the current behaviour. It just adds the possibility to set the position of the error message (if present) to a certain place in regards to the field which has the faulty value. Either before (above) or after (underneath). The latter is the default value, representing the current behaviour.

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utrecht ❌ Failed (Inspect) Oct 11, 2024 2:15pm

@remypar5 remypar5 requested a review from Robbert October 11, 2024 14:15
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (1ee8885) to head (a6d6099).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2561   +/-   ##
=======================================
  Coverage   93.63%   93.64%           
=======================================
  Files         152      152           
  Lines        1257     1258    +1     
  Branches      265      258    -7     
=======================================
+ Hits         1177     1178    +1     
- Misses         77       79    +2     
+ Partials        3        1    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant