Refactor CategorySelectionViewModel to remove Redundant code

.gitignore

@@ -41,6 +41,7 @@ captures/
 .idea/sonarlint
 .idea/misc.xml
 .idea/deploymentTargetDropDown.xml
+.idea/deploymentTargetSelector.xml
 .idea/workspace.xml
 .idea/tasks.xml
 .idea/gradle.xml

feature/category/src/main/kotlin/com/naveenapps/expensemanager/feature/category/selection/CategorySelectionViewModel.kt

@@ -20,25 +20,27 @@ class CategorySelectionViewModel @Inject constructor(
     private val _categories = MutableStateFlow<List<Category>>(emptyList())
     val categories = _categories.asStateFlow()
 
-    private val _selectedCategory = MutableStateFlow<List<Category>>(emptyList())
-    val selectedCategories = _selectedCategory.asStateFlow()
+    private val _selectedCategories = MutableStateFlow<List<Category>>(emptyList())
+    val selectedCategories = _selectedCategories.asStateFlow()
 
     init {
-        getCategoriesUseCase.invoke().map { categories ->
-            _categories.value = categories
-            if (_selectedCategory.value.isEmpty()) {
-                _selectedCategory.value = categories
-            }
-        }.launchIn(viewModelScope)
+        getCategoriesUseCase.invoke()
+                .map { categories ->
+                    _categories.value = categories
+                    if (_selectedCategories.value.isEmpty()) {
+                        _selectedCategories.value = categories
+                    }
+                }
+                .launchIn(viewModelScope)
     }
 
     fun clearChanges() {
-        _selectedCategory.value = emptyList()
+        _selectedCategories.value = emptyList()
     }
 
     fun selectThisCategory(category: Category, selected: Boolean) {
         viewModelScope.launch {
-            val selectedCategories = _selectedCategory.value.toMutableList()
+            val selectedCategories = _selectedCategories.value.toMutableList()
 
             val selectedCategory = selectedCategories.firstOrNull {
                 category.id == it.id
@@ -54,33 +56,17 @@ class CategorySelectionViewModel @Inject constructor(
                 }
             }
 
-            _selectedCategory.value = selectedCategories
+            _selectedCategories.value = selectedCategories
         }
     }
 
-    fun selectAllThisCategory(categories: List<Category>) {
-        if (categories.isEmpty()) {
-            return
-        }
+    fun selectAllTheseCategories(categories: List<Category>) {
+        categories.ifEmpty { return }
 
         viewModelScope.launch {
             clearChanges()
-
-            val selectedCategories = _selectedCategory.value.toMutableList()
-
-            repeat(categories.size) {
-                val category = categories[it]
-
-                val selectedCategory = selectedCategories.firstOrNull {
-                    category.id == it.id
-                }
-
-                if (selectedCategory == null) {
-                    selectedCategories.add(category)
-                }
-            }
-
-            _selectedCategory.value = selectedCategories
+            _selectedCategories.value = categories
         }
+
     }
 }

feature/category/src/main/kotlin/com/naveenapps/expensemanager/feature/category/selection/MultipleCategoriesSelectionScreen.kt

@@ -37,7 +37,7 @@ fun MultipleCategoriesSelectionScreen(
     selectedCategories: List<Category> = emptyList(),
     onItemSelection: ((List<Category>, Boolean) -> Unit)? = null,
 ) {
-    viewModel.selectAllThisCategory(selectedCategories)
+    viewModel.selectAllTheseCategories(selectedCategories)
 
     CategorySelectionView(viewModel, onItemSelection)
 }

feature/category/src/test/java/com/naveenapps/expensemanager/feature/category/selection/CategorySelectionViewModelTest.kt

@@ -97,7 +97,7 @@ class CategorySelectionViewModelTest : BaseCoroutineTest() {
             Truth.assertThat(firstItem).isNotEmpty()
             Truth.assertThat(firstItem).hasSize(5)
 
-            categorySelectionViewModel.selectAllThisCategory(getRandomCategoryData(3))
+            categorySelectionViewModel.selectAllTheseCategories(getRandomCategoryData(3))
 
             val secondItem = awaitItem()
             Truth.assertThat(secondItem).isEmpty()
@@ -117,7 +117,7 @@ class CategorySelectionViewModelTest : BaseCoroutineTest() {
             Truth.assertThat(firstItem).isNotEmpty()
             Truth.assertThat(firstItem).hasSize(5)
 
-            categorySelectionViewModel.selectAllThisCategory(emptyList())
+            categorySelectionViewModel.selectAllTheseCategories(emptyList())
         }
     }
 }