[No-Merge] Test Hive_view with Spark #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nk1506
force-pushed
the
hive_view_with_spark
branch
from
924b2b9 to
9117989
Compare
nk1506
commented
Mar 7, 2024
| @@ -1318,8 +1320,8 @@ public void createViewWithSubqueryExpressionInFilterThatIsRewritten() | |||
| sql("USE spark_catalog"); | |||
|
|
|||
| assertThatThrownBy(() -> sql(sql)) | |||
| .isInstanceOf(AnalysisException.class) | |||
| .hasMessageContaining(String.format("The table or view `%s` cannot be found", tableName)); | |||
| .isInstanceOf(SparkException.class) | |||
There was a problem hiding this comment.
In Case of Hive Catalog the thrown exception is type of SparkException
nk1506
commented
Mar 7, 2024
| @@ -1430,29 +1432,29 @@ public void showViews() throws NoSuchTableException { | |||
| Object[] tempView = row("", "tempviewforlisting", true); | |||
| assertThat(sql("SHOW VIEWS")) | |||
| .contains( | |||
| row(NAMESPACE.toString(), "prefixV2", false), | |||
| row(NAMESPACE.toString(), "prefixV3", false), | |||
| row(NAMESPACE.toString(), "prefixv2", false), | |||
There was a problem hiding this comment.
Hive is always returning it in lower case.
nk1506
commented
Mar 7, 2024
| + " 'provider' = 'iceberg')\n" | ||
| + "AS\n%s\n", | ||
| catalogName, NAMESPACE, viewName, NAMESPACE, viewName, sql); | ||
| catalogName, NAMESPACE, viewName, TestHiveMetastore.HIVE_LOCAL_DIR, viewName, sql); |
There was a problem hiding this comment.
Hive is initialising it's temp path with prefix hive.
nk1506
force-pushed
the
hive_view_new
branch
7 times, most recently
from
a9c09c9 to
7a83702
Compare
nk1506
force-pushed
the
hive_view_new
branch
4 times, most recently
from
b3d4525 to
57eff75
Compare
… exceptions. Add tests with Hive-View and Hive-Iceberg View. failedCommitStatusCheckSupplier for table and view with metadataLocation and versionId respectively.
Tests to do validation hive and iceberg view with the same name.
nk1506
force-pushed
the
hive_view_new
branch
2 times, most recently
from
7d44d05 to
a188863
Compare
…ts in table metadata pointing to files that doesn't exist (apache#9998) Co-authored-by: Abid Mohammed <[email protected]>
…e#10072) Bumps software.amazon.awssdk:bom from 2.25.18 to 2.25.21. --- updated-dependencies: - dependency-name: software.amazon.awssdk:bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…he#9988) Bumps org.glassfish.jaxb:jaxb-runtime from 2.3.3 to 2.3.9. --- updated-dependencies: - dependency-name: org.glassfish.jaxb:jaxb-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
nk1506
force-pushed
the
hive_view_with_spark
branch
from
9117989 to
21b4255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.