Improvements #1
Merged
Improvements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nk1506 FYI |
nk1506
reviewed
Oct 31, 2023
|
|
||
| public HiveMetastoreExtension(Map<String, String> hiveConfOverride) { | ||
| public HiveMetastoreExtension(String databaseName, Map<String, String> hiveConfOverride) { |
There was a problem hiding this comment.
Thanks for looking into it. I had plan to do the same with followup patch .
But I was more considering like multiple constructor one with only hive config, other with db and table name. The same can help to intialize the extended classed of HiveTableBaseTest
There was a problem hiding this comment.
I think it makes sense now to do the setup only with HiveMetastoreExtension all the other catalog initialisation or default table creation can happen with usage basis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.