Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: add deadnix and statix checks and clean up the warnings from them #1359

Closed
wants to merge 6 commits into from
Closed

style: add deadnix and statix checks and clean up the warnings from them #1359

wants to merge 6 commits into from

Conversation

cpcloud
Copy link
Collaborator

@cpcloud cpcloud commented Oct 25, 2023

Contribution checklist (recommended but not always applicable/required):

  • There's an automated test for this change
  • Commit messages or code include references to related issues or PRs (including third parties)
  • Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"

@cpcloud cpcloud force-pushed the more-static-checks branch 2 times, most recently from a07b6cd to b7d5b8f Compare October 25, 2023 09:48
@cpcloud cpcloud force-pushed the more-static-checks branch from ab43e06 to 166978b Compare October 25, 2023 10:37
@cpcloud cpcloud force-pushed the more-static-checks branch from 3806faa to f6c72f1 Compare October 25, 2023 10:51
@cpcloud cpcloud requested review from adisbladis and K900 October 25, 2023 19:46
@cpcloud cpcloud force-pushed the more-static-checks branch from 3bf6b70 to b63407a Compare October 25, 2023 19:48
@adisbladis adisbladis mentioned this pull request Oct 25, 2023
Merged
3 tasks
@adisbladis
Copy link
Member

Closing in favour of #1360

@adisbladis adisbladis closed this Oct 25, 2023
@cpcloud cpcloud deleted the more-static-checks branch October 25, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@K900 K900 Awaiting requested review from K900

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @adisbladis