Add alias for native-comp-deferred deny list #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Emacs versions > 28 the name of the deny list has changed, but currently `nix-doom-emacs` is pinned to an older version of Doom Emacs that doesn't have a fix for this. This change just adds a `defvaralias` in places where it doesn't exist using feature testing (instead of checking the Emacs version). This solution was originally developed by @librephoenix.
|
This should fix nix-community/nix-doom-emacs#409. |
|
Thank you! Saved my sanity. |
|
@ckiee you mentioned that you can merge this? |
|
I'm not able to test currently, my NDE checkout has a bunch of other WIP changes. |
|
Oops, didn't intend to use my work account for that. Anyway, there's no rush from me, just wanted to make sure you saw it. 😁 |
|
Thanks @codingkoi for putting the patch into a PR! I'm excited to switch back to using the official Nix Doom Emacs, rather than my unmaintained fork XD |
|
Any news ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Emacs versions > 28 the name of the deny list has changed, but currently
nix-doom-emacsis pinned to an older version of Doom Emacs that doesn't have a fix for this.This change just adds a
defvaraliasin places where it doesn't exist using feature testing (instead of checking the Emacs version).This solution was originally developed by @librephoenix.