race condition fix

nitroshare · Aug 9, 2021 · a36b8ae · a36b8ae
1 parent 678ee13
commit a36b8ae
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/src/filesystemhandler.cpp b/src/src/filesystemhandler.cpp
@@ -24,6 +24,7 @@
 #include <QFileInfo>
 #include <QFileInfoList>
 #include <QUrl>
+#include <QPointer>
 
 #include <qhttpengine/filesystemhandler.h>
 #include <qhttpengine/qiodevicecopier.h>
@@ -88,8 +89,12 @@ void FilesystemHandlerPrivate::processFile(Socket *socket, const QString &absolu
     QIODeviceCopier *copier = new QIODeviceCopier(file, socket);
     connect(copier, &QIODeviceCopier::finished, copier, &QIODeviceCopier::deleteLater);
     connect(copier, &QIODeviceCopier::finished, file, &QFile::deleteLater);
-    connect(copier, &QIODeviceCopier::finished, [socket]() {
-        socket->close();
+
+    QPointer<Socket> qps = socket;
+    connect(copier, &QIODeviceCopier::finished, [qps]() {
+        if(qps) {
+            qps->close();
+        }
     });
 
     // Stop the copier if the socket is disconnected