STY: Apply ruff/flake8-bugbear rules (B) #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3671 +/- ##
=======================================
Coverage 70.86% 70.87%
=======================================
Files 1276 1276
Lines 59229 59238 +9
Branches 9812 9812
=======================================
+ Hits 41975 41984 +9
Misses 16079 16079
Partials 1175 1175 ☔ View full report in Codecov by Sentry. |
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
force-pushed
the
B
branch
3 times, most recently
from
da32b16
to
24fcea3
Compare
DimitriPapadopoulos
force-pushed
the
B
branch
2 times, most recently
from
b89c715
to
df9c00f
Compare
effigies
reviewed
Oct 5, 2024
B004 Using `hasattr(x, "__call__")` to test if x is callable is unreliable.
Use `callable(x)` for consistent results.
B009 Do not call `getattr` with a constant attribute value.
It is not any safer than normal property access.
B010 Do not call `setattr` with a constant attribute value.
It is not any safer than normal property access.
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apply flake8-bugbear (B) rules, except: