Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to the validation script #7

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fixes to the validation script #7

wants to merge 6 commits into from

Conversation

jagruti8
Copy link

Fixed the first_validation.py file such that there is no assertion error

matthew-brett
matthew-brett reviewed Aug 17, 2022
View reviewed changes
Copy link
Contributor

@matthew-brett matthew-brett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't give you a very good test - but I think there's a problem with your second function - see the comments.

first_validation.py Outdated Show resolved Hide resolved
first_validation.py Outdated Show resolved Hide resolved
first_validation.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-brett matthew-brett matthew-brett left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jagruti8 @matthew-brett