Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to better handle externals, and more generally more than one scan in swift. #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marceltence
Copy link

move profiles and channels initialisation from init() to a separate function so that it can be easily overriden
Temporary ?
do not register/unregister component if it is an orsay_scan_device

stem_controller:
do not add channel_id ending with spim to make_scan_display_item_list
Temporary ?
does not register_instrument if it is an external_scan_controller
do not register/unregister component if it is an external_scan_controller

ScanCntrolPanel:
Temporary ?
do not register/unregister component if it is an orsay_scan_device

move profiles and channels initialisation from __init()__ to a separate function so that it can be easily override
Temporary ?
do not register/unregister component if it is an orsay_scan_device

stem_controller:
do not add channel_id ending with spim to make_scan_display_item_list
does not register_instrument if it is an external_scan_controller
do not register/unregister component if it is an external_scan_controller

ScanCntrolPanel:
Temporary ?
do not register/unregister component if it is an orsay_scan_device
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2022

CLA assistant check
All committers have signed the CLA.

@cmeyer
Copy link
Collaborator

cmeyer commented Jan 13, 2022

Thanks for this Marcel. I'm looking it over in detail.

One question: is there a reason you need to register your device as a "scan_device"? It might work to just simply not register it.

@marceltence
Copy link
Author

marceltence commented Jan 13, 2022

I suppose I need to register as a scan to use it in instrumentation kit panels.
Based on ScanContext, we can automatically link the correct scan source and update the scan source combo box.
I still need to add synchronized stuff for scan.
It also forces me to stay as close as possible to your developments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants