Example project add startup overlay #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the absence of this, has yet again this year, resulted in an ancient renin from registry.yarnpkg.com being picked up. I mean, if we encouraged by running with just refferingto renin in package.json and that was it, I'd get it. But since we require renin being in a sibling folder anyway, this is just a source of pain. And this should fix it. For now.
|
In the spirit of reducing chances to trip up, I've also tweaked the reference to Renin in the packages.json file, for the reasons stated in the commit message, which are: For some reason, the absence of this, has yet again this year, resulted in an ancient Renin from registry.yarnpkg.com being picked up. I mean, if we encouraged by running with just referring to Renin in package.json and that was it, I'd get it. But since we require Renin being in a sibling folder anyway, this is just a source of pain. And this should fix it. For now. |
trondkla
reviewed
Jul 29, 2024
| @@ -20,22 +20,24 @@ export class PostFx extends ReninNode { | |||
| }) | |||
| ); | |||
|
|
|||
| // @ts-ignore | |||
There was a problem hiding this comment.
Not a fan of all the ts-ignores. What is it complaining of?
trondkla
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was really useful. It should be there when we inevitably copy paste this project for our next production!