Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 0.3.0 #51

Merged
merged 29 commits into from
Dec 5, 2023
Merged

Release - 0.3.0 #51

merged 29 commits into from
Dec 5, 2023

Conversation

phongvhd93
Copy link
Collaborator

luongvo and others added 26 commits October 31, 2023 21:58
@luongvo
[#30] Switch the android submodule to develop-koin branch
565f9b1
@luongvo
[#30] Fix: generate the Android app module with the entered bundle id
4d1848f
@bot-nimble
[Chore] Generate & update sample project
3c0ea52
@luongvo
[#30] Create a script to generate shared module
6991848
@luongvo
[#30] Rename package & app name in the shared module
35ab48e
@bot-nimble
[Chore] Generate & update sample project
16a34a6
@luongvo
[#30] Move make_android and make_ios scripts to scripts folder
e23321e
@luongvo
[#30] Customize output folder to project name
80720b8
@bot-nimble
[Chore] Generate & update sample project
781f00d
@bot-nimble
[Chore] Generate & update sample project
ea8c6e1
@luongvo
[#30] Keep buildKonfig.properties and ignore CONTRIBUTING.md
3beea1e
@bot-nimble
[Chore] Generate & update sample project
db275ca
@phongvhd93
Merge pull request #47 from nimblehq/feature/30-complete-the-script-t…
71cbe98 
…o-generate-new-kmm-project

[#30] Complete the script to generate the whole KMM project
@lydiasama
[#6] Add CD workflow
44b9129
@lydiasama
[#6] Resolve PR comments
4f6019b
@lydiasama
[#6] Update proguard rules
db5cd5e
@bot-nimble
[Chore] Generate & update sample project
102b1f1
@luongvo
[#6] Fix: rename sample app package back to "co.nimblehq.kmm.template…
e09524d 
…" (we forgot to revert it from this PR #47)
@luongvo
[#6] Fix: update BUILD_KONFIG_PROPERTIES fetching for test.yml workflow
a8e761b
@bot-nimble
[Chore] Generate & update sample project
8bc5ac7
@luongvo
[#6] Fix: the right usage of "branches-ignore" on pull request event
9651dc9
@bot-nimble
[Chore] Generate & update sample project
7c42b39
@luongvo
[Chore] Ignore release keystore file out of git
1304814
@bot-nimble
[Chore] Generate & update sample project
3309052
@luongvo
Merge pull request #48 from nimblehq/feature/6-set-up-cd-android
9f3c513 
[#6] [Android] Set up CD workflow
@phongvhd93
Merge branch 'main' into chore/sync-main-and-release-0.3.0
9ef0dce 
# Conflicts:
#	sample/ios/sample.xcodeproj/project.pbxproj
@phongvhd93 phongvhd93 added this to the 0.3.0 milestone Dec 4, 2023
@phongvhd93 phongvhd93 self-assigned this Dec 4, 2023
@phongvhd93 phongvhd93 requested a review from suho as a code owner December 4, 2023 05:18
@phongvhd93 phongvhd93 marked this pull request as draft December 4, 2023 05:18
@phongvhd93 phongvhd93 marked this pull request as ready for review December 5, 2023 09:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

9 Warnings
⚠️ Big PR
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ android/src/main/java/co/nimblehq/kmm/template/ui/screens/home/HomeScreen.kt#L66 - This expression contains a magic number. Consider defining it to a well named constant.
⚠️ shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
⚠️ shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
⚠️ shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
⚠️ shared/src/commonTest/kotlin/co/nimblehq/kmm/template/extensions/ResponseMappingTest.kt#L18 - Exception is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
⚠️ shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
⚠️ shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: 59.92%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

.gitignore
.gitignore
.gitmodules
Gemfile.lock
Podfile.lock
README.md
README.md
android
buildKonfig.properties
buildKonfig.properties.sample
deploy_production.yml
deploy_production.yml
deploy_staging.yml
deploy_staging.yml
make.sh
make_android.sh
make_ios.sh
make_shared.kts
proguard-rules.pro
proguard-rules.pro
project.pbxproj
settings.gradle.kts
test.yml
test.yml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@phongvhd93 phongvhd93 merged commit 828f5d6 into main Dec 5, 2023
1 check passed
@phongvhd93 phongvhd93 deleted the release/0.3.0 branch December 5, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgravity markgravity markgravity approved these changes

@luongvo luongvo luongvo approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@lydiasama lydiasama Awaiting requested review from lydiasama

@AVI5HEK AVI5HEK Awaiting requested review from AVI5HEK AVI5HEK is a code owner

@kaungkhantsoe kaungkhantsoe Awaiting requested review from kaungkhantsoe kaungkhantsoe is a code owner

Assignees

@phongvhd93 phongvhd93

Labels
type : release
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@phongvhd93 @luongvo @markgravity @bot-nimble @lydiasama