generated from nimblehq/git-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#39] Optimize the workflow to generate the "sample" project before executing CI actions #38
Merged
phongvhd93
merged 12 commits into
develop
from
chore/optimize-test-workflow-to-execute-on-the-sample-project
Aug 29, 2023
Merged
[#39] Optimize the workflow to generate the "sample" project before executing CI actions #38
phongvhd93
merged 12 commits into
develop
from
chore/optimize-test-workflow-to-execute-on-the-sample-project
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luongvo
requested review from
suho,
phongvhd93,
markgravity,
lydiasama,
AVI5HEK and
kaungkhantsoe
as code owners
August 24, 2023 04:43
luongvo
force-pushed
the
chore/optimize-test-workflow-to-execute-on-the-sample-project
branch
7 times, most recently
from
August 24, 2023 08:44
c015dfd
to
d037ab3
Compare
luongvo
force-pushed
the
chore/optimize-test-workflow-to-execute-on-the-sample-project
branch
from
August 24, 2023 09:04
f269985
to
8ec2d6e
Compare
@phongvhd93 @markgravity @kaungkhantsoe This PR is now ready for review, too 🎉 |
luongvo
force-pushed
the
chore/optimize-test-workflow-to-execute-on-the-sample-project
branch
from
August 24, 2023 09:37
dac1a75
to
cf19e76
Compare
luongvo
force-pushed
the
chore/optimize-test-workflow-to-execute-on-the-sample-project
branch
from
August 25, 2023 02:03
14a0c87
to
0845d42
Compare
luongvo
changed the base branch from
develop
to
feature/17-remove-unnecessary-libs
August 25, 2023 14:38
luongvo
changed the title
[Chore] Optimize the test workflow to prepare, execute CI actions and submit the "sample" project
[Chore] Optimize the workflow to generate the "sample" project before executing CI actions
Aug 25, 2023
luongvo
changed the title
[Chore] Optimize the workflow to generate the "sample" project before executing CI actions
[#39] Optimize the workflow to generate the "sample" project before executing CI actions
Aug 25, 2023
luongvo
force-pushed
the
chore/optimize-test-workflow-to-execute-on-the-sample-project
branch
from
August 25, 2023 15:09
0845d42
to
b08ebe6
Compare
markgravity
force-pushed
the
chore/optimize-test-workflow-to-execute-on-the-sample-project
branch
from
August 28, 2023 04:16
8ff584b
to
59a1c6d
Compare
phongvhd93
force-pushed
the
feature/17-remove-unnecessary-libs
branch
from
August 28, 2023 04:21
0164ea2
to
08b288b
Compare
luongvo
force-pushed
the
chore/optimize-test-workflow-to-execute-on-the-sample-project
branch
2 times, most recently
from
August 28, 2023 09:08
de0b400
to
7bdf896
Compare
…oid or iOS platforms
luongvo
force-pushed
the
chore/optimize-test-workflow-to-execute-on-the-sample-project
branch
2 times, most recently
from
August 28, 2023 09:55
d6c9b1d
to
61a830d
Compare
luongvo
force-pushed
the
chore/optimize-test-workflow-to-execute-on-the-sample-project
branch
from
August 28, 2023 09:58
61a830d
to
87e9ce7
Compare
SwiftFormat found issues:
Current coverage for sample is
|
luongvo
force-pushed
the
chore/optimize-test-workflow-to-execute-on-the-sample-project
branch
from
August 28, 2023 10:30
87e9ce7
to
6e29f3b
Compare
phongvhd93
reviewed
Aug 28, 2023
phongvhd93
approved these changes
Aug 29, 2023
kaungkhantsoe
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
phongvhd93
deleted the
chore/optimize-test-workflow-to-execute-on-the-sample-project
branch
August 29, 2023 04:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
test.yml
workflow to generate the sample project before executing test actions on Android or iOS platforms.contribution guide
for git-submodule.Insight 📝
The Danger for iOS has an issue when running from the non-root directory:
sample/ios
, which makes the SwiftFormat can not file expected files because of duplicating thesample/ios
path https://github.com/nimblehq/kmm-templates/actions/runs/5982564343/job/16231801560 💥The cause is while
danger-ruby-swiftformat
returns the list of swift files with the full path from the root dir, e.g.sample/ios/fastlane/Constants/Constant.swift
, includingsample/ios
,SwiftFormat
joins them with the current working dir/Users/runner/work/kmm-templates/kmm-templates/sample/ios/
.There is no official support to bypass this issue. I made a workaround to modify the
danger-ruby-swiftformat
source to remove thesample/ios
prefix from all files by using this operator.map { |file| file.partition('sample/ios/').last }
🙏Proof Of Work 📹
The workflow works properly as it is.