[#13] [Part 2] Implement the base Clean Architecture with MVVM: data and domain layer #37

kaungkhantsoe · 2023-08-22T11:04:49Z

Close Implement the base Clean Architecture with MVVM: data and domain layer #13

What happened 👀

Add buildSrc and extract dependencies
Add Koin DI
Add Ktor

Insight 📝

N/A

Proof Of Work 📹

bot-nimble · 2023-08-22T11:09:37Z

shared/src/commonTest/kotlin/co/nimblehq/kmm/template/domain/usecase/GetUsersUseCaseTest.kt

+    }
+
+    @Test
+    fun `When calling getUsersUseCase successfully - it returns users`() = runTest {


⚠️ Function names should match the pattern: [a-zA-Z][a-zA-Z0-9]*

bot-nimble · 2023-08-22T11:09:38Z

	11 Warnings
⚠️	Big PR
⚠️	Uh oh! ApiClient.kt is under 95% coverage!
⚠️	Uh oh! ApiException.kt is under 95% coverage!
⚠️	Uh oh! HttpRequestBuilderExtension.kt is under 95% coverage!
⚠️	Uh oh! UserRemoteDataSource.kt is under 95% coverage!
⚠️	Uh oh! Your project is under 80% coverage!
⚠️	shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
⚠️	shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
⚠️	shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
⚠️	shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
⚠️	shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: `10.68%`

Coverage of Modified Files:

File	Coverage
`ApiClient.kt`	`0.00%`
`ApiException.kt`	`0.00%`
`GetUsersUseCase.kt`	`100.00%`
`HttpRequestBuilderExtension.kt`	`0.00%`
`RepositoryImpl.kt`	`100.00%`
`ResponseMapping.kt`	`100.00%`
`UserModel.kt`	`100.00%`
`UserRemoteDataSource.kt`	`0.00%`
`UserResponse.kt`	`100.00%`

Modified Files Not Found In Coverage Report:

.gitignore
AndroidManifest.xml
Configurations.kt
Dependencies.kt
Fake.kt
GetUsersUseCaseTest.kt
PlatformModule.kt
PlatformModule.kt
RemoteModule.kt
Repository.kt
RepositoryModule.kt
RepositoryTest.kt
ResponseMappingTest.kt
UseCaseModule.kt
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
buildKonfig.properties.sample
detekt.yml
detekt.yml
test.yml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

luongvo

Some early reviews for you 👋

android/build.gradle.kts

buildKonfig.properties

buildSrc/src/main/java/Configurations.kt

buildSrc/src/main/java/Dependencies.kt

...src/commonMain/kotlin/co/nimblehq/kmm/template/data/extension/HttpRequestBuilderExtension.kt

shared/src/commonMain/kotlin/co/nimblehq/kmm/template/domain/repository/Repository.kt

shared/src/commonMain/kotlin/co/nimblehq/kmm/template/domain/usecase/GetUsersUseCase.kt

shared/src/commonTest/kotlin/co/nimblehq/kmm/template/domain/usecase/GetUsersUseCaseTest.kt

shared/src/commonTest/kotlin/co/nimblehq/kmm/template/util/TestUtil.kt

shared/src/commonTest/kotlin/co/nimblehq/kmm/template/domain/usecases/GetUsersUseCaseTest.kt

luongvo · 2023-08-23T09:49:24Z

@kaungkhantsoe is this PR ready for review yet?

kaungkhantsoe · 2023-08-23T09:50:34Z

@kaungkhantsoe is this PR ready for review yet?

Not yet @luongvo, I am still working on it. 🙏

.github/workflows/test.yml

buildSrc/src/main/java/Dependencies.kt

shared/src/commonMain/kotlin/co/nimblehq/kmm/template/data/repository/RepositoryImpl.kt

...ed/src/commonMain/kotlin/co/nimblehq/kmm/template/data/remote/model/response/UserResponse.kt

shared/build.gradle.kts

build.gradle.kts

buildSrc/src/main/java/Dependencies.kt

…alues

shared/src/commonTest/kotlin/co/nimblehq/kmm/template/domain/usecases/GetUsersUseCaseTest.kt

android/build.gradle.kts

shared/build.gradle.kts

shared/src/commonTest/kotlin/co/nimblehq/kmm/template/domain/usecases/GetUsersUseCaseTest.kt

shared/src/commonMain/kotlin/co/nimblehq/kmm/template/data/extensions/ResponseMapping.kt

shared/src/commonMain/kotlin/co/nimblehq/kmm/template/data/remote/ApiClient.kt

build.gradle.kts

buildKonfig.properties.sample

shared/build.gradle.kts

…olves

shared/src/commonTest/kotlin/co/nimblehq/kmm/template/extensions/ResponseMappingTest.kt

build.gradle.kts

shared/src/commonMain/kotlin/co/nimblehq/kmm/template/data/extensions/ResponseMapping.kt

buildSrc/src/main/java/Dependencies.kt

luongvo

All good now

kaungkhantsoe self-assigned this Aug 22, 2023

bot-nimble reviewed Aug 22, 2023

View reviewed changes

luongvo reviewed Aug 23, 2023

View reviewed changes

Base automatically changed from feature/13-part-1-implement-koin-di-and-extract-dependencies to develop August 23, 2023 08:17

kaungkhantsoe force-pushed the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch from 4651efc to eed3db7 Compare August 23, 2023 08:30

bot-nimble reviewed Aug 23, 2023

View reviewed changes

shared/src/commonTest/kotlin/co/nimblehq/kmm/template/domain/usecases/GetUsersUseCaseTest.kt Outdated Show resolved Hide resolved

kaungkhantsoe force-pushed the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch from 26fdb62 to b6c14ee Compare August 23, 2023 08:51

kaungkhantsoe added 5 commits August 23, 2023 16:34

[#13] Change jdk version to 17

c61582c

[#13] Reorder by Dependencies and minor refactors from review

c0f9f29

[#13] Remove buildKonfig.properties

5df1058

[#13] Update gitignore for buildKonfig

1e82914

[#13] Update CI to decode buildKonfig

fdb38af

kaungkhantsoe force-pushed the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch from fde1683 to ba86c47 Compare August 23, 2023 09:37

kaungkhantsoe requested a review from luongvo August 23, 2023 09:39

kaungkhantsoe force-pushed the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch from 2ada03f to d31fefd Compare August 23, 2023 11:13

kaungkhantsoe added the type : feature label Aug 23, 2023

kaungkhantsoe added this to the 0.1.0 milestone Aug 23, 2023

kaungkhantsoe marked this pull request as ready for review August 23, 2023 11:16

kaungkhantsoe requested review from suho, phongvhd93, markgravity, lydiasama and AVI5HEK as code owners August 23, 2023 11:16

kaungkhantsoe added 2 commits August 23, 2023 19:06

[#13] Implement datasource, responses and di

c7359ed

[#13] Add internet permission for android

13dde54

kaungkhantsoe force-pushed the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch from ed7140a to 13dde54 Compare August 23, 2023 12:13

luongvo requested changes Aug 24, 2023

View reviewed changes

[#13] Add repository test cases and fix RepositoryImpl not emitting v…

4c14109

…alues

kaungkhantsoe force-pushed the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch from 79edc9f to 4c14109 Compare August 24, 2023 07:40

bot-nimble reviewed Aug 24, 2023

View reviewed changes

shared/src/commonTest/kotlin/co/nimblehq/kmm/template/domain/usecases/GetUsersUseCaseTest.kt Outdated Show resolved Hide resolved

kaungkhantsoe force-pushed the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch from c72e7ef to 111c067 Compare August 24, 2023 09:07

kaungkhantsoe requested a review from luongvo August 24, 2023 09:07

luongvo requested changes Aug 24, 2023

View reviewed changes

phongvhd93 added the Need Review 👋 label Aug 24, 2023

luongvo mentioned this pull request Aug 24, 2023

[#5] [iOS] Setup CI: Github Actions #23

Merged

[#13] Add JsonApi, move dependencies to plugins and minor reviews res…

84fbc5c

…olves

kaungkhantsoe force-pushed the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch from 97f232c to 84fbc5c Compare August 25, 2023 03:40

kaungkhantsoe requested a review from luongvo August 25, 2023 03:40

bot-nimble reviewed Aug 25, 2023

View reviewed changes

shared/src/commonTest/kotlin/co/nimblehq/kmm/template/extensions/ResponseMappingTest.kt Show resolved Hide resolved

kaungkhantsoe force-pushed the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch from b8f8e1d to d0922a6 Compare August 25, 2023 03:51

[#13] Remove Koin dependency from AndroidMain

4f3eff3

kaungkhantsoe force-pushed the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch from d0922a6 to 4f3eff3 Compare August 25, 2023 03:59

luongvo reviewed Aug 25, 2023

View reviewed changes

build.gradle.kts Outdated Show resolved Hide resolved

shared/src/commonMain/kotlin/co/nimblehq/kmm/template/data/extensions/ResponseMapping.kt Outdated Show resolved Hide resolved

buildSrc/src/main/java/Dependencies.kt Outdated Show resolved Hide resolved

[#13] Remove redundant code lines and add mappError

bc97bff

kaungkhantsoe force-pushed the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch from 26926a6 to bc97bff Compare August 25, 2023 04:19

kaungkhantsoe requested a review from luongvo August 25, 2023 04:20

[Chore] Generate & update sample project

50c1133

luongvo approved these changes Aug 25, 2023

View reviewed changes

phongvhd93 approved these changes Aug 25, 2023

View reviewed changes

phongvhd93 merged commit bdadd78 into develop Aug 25, 2023

phongvhd93 deleted the feature/13-part-2-implement-ktor-and-backend-tasks-with-new branch August 25, 2023 04:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#13] [Part 2] Implement the base Clean Architecture with MVVM: data and domain layer #37

[#13] [Part 2] Implement the base Clean Architecture with MVVM: data and domain layer #37

kaungkhantsoe commented Aug 22, 2023 •

edited

Loading

bot-nimble Aug 22, 2023

bot-nimble commented Aug 22, 2023 •

edited

Loading

luongvo left a comment

luongvo commented Aug 23, 2023

kaungkhantsoe commented Aug 23, 2023

luongvo left a comment

[#13] [Part 2] Implement the base Clean Architecture with MVVM: data and domain layer #37

[#13] [Part 2] Implement the base Clean Architecture with MVVM: data and domain layer #37

Conversation

kaungkhantsoe commented Aug 22, 2023 • edited Loading

What happened 👀

Insight 📝

Proof Of Work 📹

bot-nimble Aug 22, 2023

Choose a reason for hiding this comment

bot-nimble commented Aug 22, 2023 • edited Loading

Kover report:

🧛 Unit Tests Code Coverage: 10.68%

Coverage of Modified Files:

Modified Files Not Found In Coverage Report:

luongvo left a comment

Choose a reason for hiding this comment

luongvo commented Aug 23, 2023

kaungkhantsoe commented Aug 23, 2023

luongvo left a comment

Choose a reason for hiding this comment

kaungkhantsoe commented Aug 22, 2023 •

edited

Loading

bot-nimble commented Aug 22, 2023 •

edited

Loading

🧛 Unit Tests Code Coverage: `10.68%`