[109] Fix: Cannot run a project if it does not have any DB migration #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carryall
requested review from
hoangmirs,
malparty,
Nihisil and
suphanatjarukulgowit
as code owners
malparty
reviewed
Oct 2, 2023
| log.Fatalf("Failed to migrate database: %v", err) | ||
| } | ||
|
|
||
| log.Println("Migrated database successfully.") |
There was a problem hiding this comment.
Suggested change
| log.Println("Migrated database successfully.") | |
| log.Println("Database migrated successfully.") |
😇
There was a problem hiding this comment.
Thanks, changed in 4611bd3
malparty
reviewed
Oct 2, 2023
malparty
reviewed
Oct 2, 2023
{{cookiecutter.app_name}}/Makefile
Outdated
Comment on lines
16
to
19
| ifneq ("$(wildcard $(database/migrations/.keep))","") | ||
| goose -dir database/migrations -table "migration_versions" postgres "$(DATABASE_URL)" up | ||
| else | ||
| $(info NO migration files to run) |
There was a problem hiding this comment.
Suggested change
| ifneq ("$(wildcard $(database/migrations/.keep))","") | |
| goose -dir database/migrations -table "migration_versions" postgres "$(DATABASE_URL)" up | |
| else | |
| $(info NO migration files to run) | |
| ifeq ("$(wildcard $(database/migrations/.keep))","") | |
| $(info NO migration files to run) | |
| else | |
| goose -dir database/migrations -table "migration_versions" postgres "$(DATABASE_URL)" up |
Not sure if that work, but can we use an ifeq so we don't need to process the negative form (if NOT X do A else B vs if X do B else A`)
There was a problem hiding this comment.
It works so changed in 1183eb4 🙌🏼
malparty
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #109
What happened 👀
Insight 📝
N/A
Proof Of Work 📹
After generating the app, install the dependencies and run
make devBefore: the app crashed because there was NO migration file to run
Screen.Recording.2566-09-29.at.17.47.12.mov
After: the app is runnable with the message tells there's no migration file
Screen.Recording.2566-09-29.at.17.38.18.mov
The health API works! 🎉
