Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#72] [UI] As the user, I can see the survey question #73

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

nkhanh44
Copy link
Collaborator

@nkhanh44 nkhanh44 commented Aug 31, 2023

What happened 👀

  • Implemented survey question screen
  • Rename survey_screen -> survey_detail_screen, so I can get the survey_screen for the questions 🥲.

Insight 📝

  • I renamed the survey_screen to survey_detail_screen, but it still showed the changes, so no need to review it survey_detail_screen again 🙏 .

  • The structure of the survey screen will contain the survey_question, and all survey_answer like thumbs-up - textfield... will be in the survey_question.

👇

survey_screen
--survey_question
----survey_answer

Proof Of Work 📹

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-31.at.10.14.07.mp4

@nkhanh44 nkhanh44 added this to the 0.5.0 milestone Aug 31, 2023
@nkhanh44 nkhanh44 self-assigned this Aug 31, 2023
@nkhanh44 nkhanh44 force-pushed the feature/72-ui-survey-question branch from c6281ef to e1bd60b Compare August 31, 2023 03:45
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0f3a00b) 49.49% compared to head (7889022) 49.49%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #73   +/-   ##
========================================
  Coverage    49.49%   49.49%           
========================================
  Files           36       36           
  Lines          396      396           
========================================
  Hits           196      196           
  Misses         200      200           
Flag Coverage Δ
unittests 49.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkhanh44 nkhanh44 force-pushed the feature/72-ui-survey-question branch from e1bd60b to 525c0ea Compare August 31, 2023 03:47
@nkhanh44 nkhanh44 marked this pull request as ready for review August 31, 2023 03:56
Copy link

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

assets/images/2.0x/close_button.png Outdated Show resolved Hide resolved
lib/l10n/app_en.arb Outdated Show resolved Hide resolved
lib/screens/survey/survey_screen.dart Outdated Show resolved Hide resolved
lib/screens/survey/survey_screen.dart Outdated Show resolved Hide resolved
@nkhanh44 nkhanh44 force-pushed the feature/72-ui-survey-question branch from 525c0ea to ff10eff Compare August 31, 2023 08:39
Copy link

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now 🚀

Copy link
Collaborator

@Thieurom Thieurom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nkhanh44 nkhanh44 merged commit e1678b1 into develop Aug 31, 2023
4 checks passed
@nkhanh44 nkhanh44 deleted the feature/72-ui-survey-question branch August 31, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] As the user, I can see the survey question
3 participants