Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5] [UI] As a user, I can see the Splash screen #50

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

nkhanh44
Copy link
Collaborator

@nkhanh44 nkhanh44 commented Aug 8, 2023

What happened 👀

  • Added images
  • Implemented Splash screen

Insight 📝

Proof Of Work 📹

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-08.at.14.57.59.mp4

@nkhanh44 nkhanh44 added this to the 0.2.0 milestone Aug 8, 2023
@nkhanh44 nkhanh44 self-assigned this Aug 8, 2023
@nkhanh44 nkhanh44 changed the title [WIP] [UI] As a user, I can see the Splash screen [WIP] [#5] [UI] As a user, I can see the Splash screen Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d6d546c) 19.23% compared to head (9a6d4f5) 19.23%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #50   +/-   ##
========================================
  Coverage    19.23%   19.23%           
========================================
  Files            3        3           
  Lines           52       52           
========================================
  Hits            10       10           
  Misses          42       42           
Flag Coverage Δ
unittests 19.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkhanh44 nkhanh44 changed the title [WIP] [#5] [UI] As a user, I can see the Splash screen [#5] [UI] As a user, I can see the Splash screen Aug 8, 2023
@nkhanh44 nkhanh44 marked this pull request as ready for review August 8, 2023 06:36
@nkhanh44 nkhanh44 added the @0.2.0 label Aug 8, 2023
lib/screens/splash/splash.dart Outdated Show resolved Hide resolved
lib/main.dart Outdated Show resolved Hide resolved
assets/images/splash_logo_white.png Outdated Show resolved Hide resolved
Copy link

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

lib/main.dart Outdated Show resolved Hide resolved
lib/screens/splash/splash.dart Outdated Show resolved Hide resolved
lib/screens/splash/splash.dart Outdated Show resolved Hide resolved
Copy link

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now 💯

Copy link
Collaborator

@Thieurom Thieurom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

lib/screens/splash/splash.dart Outdated Show resolved Hide resolved
lib/screens/splash/splash.dart Outdated Show resolved Hide resolved
@nkhanh44 nkhanh44 merged commit 9a13831 into develop Aug 8, 2023
5 checks passed
@nkhanh44 nkhanh44 deleted the feature/5-ui-splash-screen branch August 8, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] As a user, I can see the Splash screen
3 participants