fix memory corruption when using standalone heap #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Fix using the standalone heap (enabled with `--os:standalone` or `-d:StandaloneHeapSize`) resulting in memory corruption due to incorrect page alignment. Details ======= The initial pointer for the array-based page allocator is now aligned to the size of a page, which ensures that `osAllocPages` always returns a page-aligned pointer (the default allocator relies on this to be the case). A test is added to ensure that simple allocation/deallocation works when using the array-based page allocator.
saem
approved these changes
Dec 20, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix using the standalone heap (enabled with
--os:standaloneor-d:StandaloneHeapSize) resulting in memory corruption due toincorrect page alignment.
Details
The initial pointer for the array-based page allocator is now aligned
to the size of a page, which ensures that
osAllocPagesalways returnsa page-aligned pointer (the default allocator relies on this to be the
case).
A test is added to ensure that simple allocation/deallocation works
when using the array-based page allocator.