ci: split into smaller workflows with some improvements #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the main workflow runs in stages for each of the tested platforms. However, this poses a problem where a stage is blocked by the slowest runner and none of the other runners could move on. With the release of reusable workflows for Actions, we can now separate the stages into a different workflow, then parallelize that instead, allowing faster runners to proceed through test stages ahead of the rest. The response time for test results should now be greatly improved, with the M1 runner finishing its run in just 7 minutes. This separation also opened the doors to customizing how tests are run for each platforms, and we now only use 1 test batch for *nix while allocating 3 to Windows. This normalizes test time between Windows and *nix, while allowing freed up runners to process other jobs. Lastly, some tiny QoL improvements are added to the pipeline: - Test failures will now be displayed at the end of "Run tester" step, reducing the number of clicks required to see all failures to 1. - The diffoscope container is now used instead of the Ubuntu package, reducing installation time and let us receive latest features/bug fixes. - If there is a diffoscope failure, a test summary is now generated with a link to the test report. This should make it a lot easier to get to the report should that be necessary.
|
/merge |
|
Merge requested by: @alaviss Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR splits our big CI workflow into smaller reusable workflows,
enabling a greater degree of parallelization and improve
maintainability.
Details
Previously, the main workflow runs in stages for each of the tested
platforms. However, this poses a problem where a stage is blocked by the
slowest runner and none of the other runners could move on.
With the release of reusable workflows for Actions, we can now separate
the stages into a different workflow, then parallelize that instead,
allowing faster runners to proceed through test stages ahead of the
rest. The response time for test results should now be greatly improved,
with the M1 runner finishing its run in just 7 minutes.
This separation also opened the doors to customizing how tests are run
for each platforms, and we now only use 1 test batch for *nix while
allocating 3 to Windows. This normalizes test time between Windows and
*nix, while allowing freed up runners to process other jobs.
Lastly, some tiny QoL improvements are added to the pipeline:
reducing the number of clicks required to see all failures to 1.
reducing installation time and let us receive latest features/bug
fixes.
a link to the test report. This should make it a lot easier to get to
the report should that be necessary.