fix(sem): crash with procedure with error used as argument #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Fix a compiler crash when passing the name of a procedure with an error as an argument to another routine. Details ======= Overloadable and overloaded procedure symbols forewent the `nkError` wrapping done by `semSym`, thus not preventing instantiation or later inspection by `sempass2`, crashing the compiler with an `IndexDefect` on attempting to access the symbol's AST. Non-overloaded procedure symbols can be passed to `semSym` directly, which takes care of the wrapping. To handle overloaded symbols, `sigmatch.paramTypesMatch` passes the picked symbol to `semExpr` first, which subsequently calls `semSym`, also marking the symbols as used. The problem with using `semExpr` in `paramTypesMatch` is that the returned `nkError` currently dismisses the overload, resulting in an unnecessary "type mismatch" compiler error (with `nimsuggest`, `check`, etc.).
zerbina
added
bug
saem
approved these changes
Sep 2, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
|
The problem with calling Either the error wrapping needs to be split out of |
`semSym` would call `markUsed` on the symbol again, resulting in a duplicate usage being reported with `nimsuggest`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a compiler crash when passing the name of a procedure with an error
as an argument to another routine.
Details
Overloadable and overloaded procedure symbols forewent the
nkErrorwrapping done by
semSym, thus not preventing instantiation or laterinspection by
sempass2, crashing the compiler with anIndexDefecton attempting to access the symbol's AST.
Non-overloaded procedure symbols can be passed to
semSymdirectly,which takes care of the wrapping. To handle overloaded symbols,
sigmatch.paramTypesMatchpasses the picked symbol tosemExprfirst,which subsequently calls
semSym, also marking the symbols as used.The problem with using
semExprinparamTypesMatchis that thereturned
nkErrorcurrently dismisses the overload, resulting in anunnecessary "type mismatch" compiler error (with
nimsuggest,check,etc.).
Fixes #1384.
Fixes #1442.