sem: keep shape of array constructors in typed AST #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't drop the `nkExprColonExpr` nodes during analysis of array constructions, so that macros can inspect the full AST and that the typed AST can be properly re-analyzed.
Folding is one case where the change in `nkBracket` syntax shows up. The output of folding still expects bracket trees without the index parts, so the `nkExprColonExpr` nodes are simply skipped.
The index part is not relevant beyond `transf`, so `transf` can simply drop it. This is also necessary, since `nkExprColonExpr` in `nkBracket` expression is not something that code operating on transformed AST expects.
zerbina
added
the
compiler/sem
|
While #1192 is not my focus at the moment, the change was easy enough that I figured I implement it right away. |
saem
approved these changes
Jun 8, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Explicit indices in array constructors now stay in the AST after
typing. Since macros are able to observe this, this change is a
breaking change.
Details
Keeping the explicit indices is also necessary for being able to
retype the AST after it was typed once (without the index, array
constructors for arrays not starting at zero would have a
different type afterwards).
Instead of dropping the explicit index together with the parent
nkExprColonExprnode, both are kept bysemArrayConstr, and thenlater discarded by
semfold(during constant evaluation) andtransf,where they are no longer needed.