Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to install from nimble file #1022

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elcritch
Copy link
Contributor

This PR adds an option to the install command to work from a local Nimble file. This makes it just a bit easier to install a package or dependencies in a CI or environment setup scripts. Doing a cd pkgdir && nimble ... can be annoying in some CI scripts. I figured an explicit option produced cleaner code and semantics than just checking if a pkgname ended with a ".nimble" extension. Though doing a local:// or file:// might another option.

Really it's not a necessary feature and partly I was motived partly by adding a small feature to Nimble to learn about it. If it's handy, great, if not no worries! :)

Examples:

./nimble install --depsOnly --nimble-file testpkg/testpkg.nimble 
./nimble install --nimble-file testpkg/testpkg.nimble 

Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together.

Two things:

  • CI failing
  • I think actually detecting whether the argument is an existing file would work quite well. Specifically restricted to .nimble files. No need for the --nimble-file flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants