Add support for arm64 on linux #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @ringabout,
following the changes for #54 and following how Crystal does it, this is an attempt to add support for Linux ARM64 (you may want to use aarch64 instead, as you wish, but Asahi linux identifies itself as
linux_arm64so I think you may want to support both?).In order to this PR to work, you need to request credits to ARM itself by opening an issue, but as far as I see, it should be fine as Nim is fully opensource.
Unfortunately, you need to discuss details with them directly via email, as I'm not officially part of the Nim "organization" (probably you will be contacted by @shipra-ps, maybe they can help in here directly?).
You may need to supply the
github.run_idthey provide and adapt/play a bit with the CI yaml, but I hope this is a kickstart.Thanks!