Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support load after watch #569

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Support load after watch #569

merged 5 commits into from
Nov 21, 2024

Conversation

ktong
Copy link
Collaborator

@ktong ktong commented Nov 21, 2024

Currently, if Config.Watch is called, any change on a loader loaded after that do not reflect to the configuration because it's not on the watch. This PR removes the chronological order between Config.Load and Config.Watch, so they can be called in different goroutines.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (1685aa7) to head (fb363fa).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #569   +/-   ##
=====================================
  Coverage   82.8%   82.8%           
=====================================
  Files         62      62           
  Lines       3304    3305    +1     
=====================================
+ Hits        2737    2738    +1     
  Misses       483     483           
  Partials      84      84           
Files with missing lines Coverage Δ
config.go 96.9% <100.0%> (+<0.1%) ⬆️
internal/nocopy.go 100.0% <100.0%> (ø)
watch.go 100.0% <100.0%> (ø)
---- 🚨 Try these New Features:

@ktong ktong enabled auto-merge (squash) November 21, 2024 02:41
@ktong ktong merged commit 31f0b86 into main Nov 21, 2024
66 checks passed
@ktong ktong deleted the kt_con branch November 21, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant