Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Config.Load concurrent-safe #567

Merged
merged 3 commits into from
Nov 20, 2024
Merged

make Config.Load concurrent-safe #567

merged 3 commits into from
Nov 20, 2024

Conversation

ktong
Copy link
Collaborator

@ktong ktong commented Nov 20, 2024

So Load and Watch can be called on different goroutines.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.0%. Comparing base (a2af1b4) to head (cdb9243).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #567   +/-   ##
=====================================
  Coverage   82.9%   83.0%           
=====================================
  Files         62      62           
  Lines       3294    3303    +9     
=====================================
+ Hits        2733    2742    +9     
  Misses       478     478           
  Partials      83      83           
Files with missing lines Coverage Δ
config.go 100.0% <100.0%> (ø)
default.go 100.0% <ø> (ø)
provider.go 100.0% <100.0%> (ø)
watch.go 100.0% <100.0%> (ø)
---- 🚨 Try these New Features:

@ktong ktong merged commit 3138d90 into main Nov 20, 2024
68 checks passed
@ktong ktong deleted the kt_type branch November 20, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant