Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Watch and OnChange for watching configuration changes #52

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Conversation

ktong
Copy link
Collaborator

@ktong ktong commented Nov 12, 2023

No description provided.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #52 (b4b0d12) into main (0b6c053) will increase coverage by 0.96%.
The diff coverage is 95.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   77.21%   78.17%   +0.96%     
==========================================
  Files          17       17              
  Lines         610      637      +27     
==========================================
+ Hits          471      498      +27     
  Misses        129      129              
  Partials       10       10              
Components Coverage Δ
konf 97.56% <95.79%> (+0.19%) ⬆️
file 71.11% <ø> (ø)
pflag 41.57% <ø> (ø)
Files Coverage Δ
global.go 100.00% <100.00%> (ø)
option.go 100.00% <100.00%> (ø)
config.go 96.12% <95.45%> (+0.81%) ⬆️

@ktong ktong force-pushed the kt_watch branch 2 times, most recently from 49f2044 to 25c3129 Compare November 12, 2023 23:40
@ktong ktong merged commit 38d5dd5 into main Nov 13, 2023
15 of 16 checks passed
@ktong ktong deleted the kt_watch branch November 13, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant