Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release script #103

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix release script #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76b3780
fix release script
ktong Feb 8, 2024
dfcfaa0
fix tests
ktong Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
owner: context.repo.owner,
repo: context.repo.repo,
tag_name: "v${{ steps.query-release-info.outputs.version }}",
target_commitish: context.sha
name: "v${{ steps.query-release-info.outputs.version }}"
target_commitish: context.sha,
name: "v${{ steps.query-release-info.outputs.version }}",
body: "${{ steps.query-release-info.outputs.release-notes }}"
})
11 changes: 1 addition & 10 deletions provider/file/watch_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright (c) 2024 The konf authors
// Use of this source code is governed by a MIT license found in the LICENSE file.

//go:build !race

package file_test

import (
Expand All @@ -25,13 +23,6 @@ func TestFile_Watch(t *testing.T) {
action func(string) error
expected map[string]any
}{
{
description: "create",
action: func(path string) error {
return os.WriteFile(path, []byte(`{"p": {"k": "v"}}`), 0o600)
},
expected: map[string]any{"p": map[string]any{"k": "v"}},
},
{
description: "write",
action: func(path string) error {
Expand Down Expand Up @@ -69,7 +60,7 @@ func TestFile_Watch(t *testing.T) {
assert.NoError(t, err)
}()

time.Sleep(time.Millisecond)
time.Sleep(100 * time.Millisecond)
assert.NoError(t, testcase.action(tmpFile))
waitGroup.Wait()
assert.Equal(t, testcase.expected, values)
Expand Down
Loading