Remove file.WithLog to favor standard log.Printf (#32)

CHANGELOG.md

@@ -7,6 +7,9 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+### Removed
+- Remove file.WithLog to favor standard log.Printf (#32).
+
 ## [v0.1.0] - 3/12/2023
 
 Initial alpha release.

provider/file/file.go

@@ -17,6 +17,7 @@ package file
 import (
 	"fmt"
 	"io/fs"
+	"log"
 	"os"
 )
 
@@ -26,7 +27,6 @@ type File struct {
 	fs             fs.FS
 	path           string
 	unmarshal      func([]byte, any) error
-	log            func(...any)
 	ignoreNotExist bool
 }
 
@@ -47,7 +47,7 @@ func (f File) Load() (map[string]any, error) {
 	}
 	if err != nil {
 		if f.ignoreNotExist && os.IsNotExist(err) {
-			f.log(fmt.Sprintf("Config file %s does not exist.", f.path))
+			log.Printf("Config file %s does not exist.", f.path)
 
 			return make(map[string]any), nil
 		}

provider/file/file_test.go

@@ -6,9 +6,11 @@
 package file_test
 
 import (
+	"bytes"
 	"context"
 	"errors"
 	"io/fs"
+	"log"
 	"os"
 	"path/filepath"
 	"strings"
@@ -121,21 +123,17 @@ func TestFile_Load(t *testing.T) {
 }
 
 func TestFile_log(t *testing.T) {
-	t.Parallel()
+	buf := new(bytes.Buffer)
+	log.SetOutput(buf)
+	log.SetFlags(0)
 
-	var log []any
 	_, err := file.New(
 		"not_found.json",
 		file.IgnoreFileNotExit(),
-		file.WithLog(
-			func(a ...any) {
-				log = append(log, a...)
-			},
-		),
 	).Load()
 
 	require.NoError(t, err)
-	require.Equal(t, []any{"Config file not_found.json does not exist."}, log)
+	require.Equal(t, "Config file not_found.json does not exist.\n", buf.String())
 }
 
 func TestFile_Watch(t *testing.T) {

provider/file/option.go

@@ -6,7 +6,6 @@ package file
 import (
 	"encoding/json"
 	"io/fs"
-	"log"
 )
 
 // WithFS provides the fs.FS that config file is loaded from.
@@ -34,15 +33,6 @@ func IgnoreFileNotExit() Option {
 	}
 }
 
-// WithLog provides the function that logs message.
-//
-// The default function [log.Print].
-func WithLog(log func(...any)) Option {
-	return func(file *options) {
-		file.log = log
-	}
-}
-
 // Option configures the given File.
 type Option func(file *options)
 
@@ -52,7 +42,6 @@ func apply(path string, opts []Option) options {
 	option := &options{
 		path:      path,
 		unmarshal: json.Unmarshal,
-		log:       log.Print,
 	}
 	for _, opt := range opts {
 		opt(option)

provider/file/watch.go

@@ -8,6 +8,7 @@ package file
 import (
 	"context"
 	"fmt"
+	"log"
 	"path/filepath"
 	"time"
 
@@ -25,7 +26,7 @@ func (f File) Watch(ctx context.Context, watchFunc func(map[string]any)) error {
 	}
 	defer func() {
 		if err := watcher.Close(); err != nil {
-			f.log(fmt.Sprintf("Error when closing watcher for %s: %v", f.path, err))
+			log.Printf("Error when closing watcher for %s: %v", f.path, err)
 		}
 	}()
 
@@ -72,12 +73,12 @@ func (f File) Watch(ctx context.Context, watchFunc func(map[string]any)) error {
 
 			switch {
 			case event.Has(fsnotify.Remove):
-				f.log(fmt.Sprintf("Config file %s has been removed.", f.path))
+				log.Printf("Config file %s has been removed.", f.path)
 				watchFunc(nil)
 			case event.Has(fsnotify.Create) || event.Has(fsnotify.Write):
 				values, err := f.Load()
 				if err != nil {
-					f.log(fmt.Sprintf("Error when reloading configuration from %s: %v", f.path, err))
+					log.Printf("Error when reloading configuration from %s: %v", f.path, err)
 
 					continue
 				}
@@ -89,7 +90,7 @@ func (f File) Watch(ctx context.Context, watchFunc func(map[string]any)) error {
 				return nil
 			}
 
-			f.log(fmt.Sprintf("Error when watching file %s: %v", f.path, err))
+			log.Printf("Error when watching file %s: %v", f.path, err)
 
 		case <-ctx.Done():
 			return nil

provider/file/watch_unsupported.go

@@ -5,10 +5,8 @@
 
 package file
 
-import "fmt"
-
 func (f File) Watch(context.Context, func(map[string]any)) error {
-	f.log(fmt.Sprintf("File.Watch does not supported on %s.", runtime.GOOS))
+	log.Printf("File.Watch does not supported on %s.", runtime.GOOS)
 
 	return nil
 }