glade: label wrapping #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids horizontal scrolling.
The label wrapping caused excessive height
Most number fields were displayed too short to show the complete number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tested your branch on debian/buster I noticed in the configure window extreme horizontal scrolling. I changed the labels in this PR to automatically wrap, so that the content fits the window size.
Additionally, I defined the number of characters for number fields, as the default width was not enough, for example to fit/display a port number.
In the "Advanced" tab I had to replace the table for the core priority to a grid, as the wrapped labels had some weird vertical spacing.
This spacing still occurs in the Optimizations section - however, I don't see that section on my client and didn't want to change this w/o the ability to test this: