Skip to content
This repository has been archived by the owner on Feb 21, 2021. It is now read-only.

Added Quicksort in C++ fixes issue #12 . #44

Closed
wants to merge 2 commits into from
Closed

Added Quicksort in C++ fixes issue #12 . #44

wants to merge 2 commits into from

Conversation

Roshan13046
Copy link
Contributor

Issue no #12 fixed.
Quicksort algorithm in c++ added.
Please check.
Thank you.

Copy link
Owner

@nikochiko nikochiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Few small changes and this will be ready to go.
Apart from the mentioned comment, also change the filename from quick_sort.cpp.cpp to quick_sort.cpp.

Comment on lines 74 to 77

int arr[]= {2,4,3,6,9,8, -1};
int n = sizeof(arr)/sizeof(arr[0]);

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we take this input from STDIN.
First line: N - number of inputs
Second line: N space-separated integers

for example,

5
2 5 23 14 4

@Roshan13046
Copy link
Contributor Author

Roshan13046 commented Oct 2, 2020

Nice work! Few small changes and this will be ready to go.
Apart from the mentioned comment, also change the filename from quick_sort.cpp.cpp to quick_sort.cpp.

Done the suggested changes.
Please check.
Thanks.

Copy link
Owner

@nikochiko nikochiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍

@Roshan13046
Copy link
Contributor Author

Great job! 👍

Thanks.

@nikochiko
Copy link
Owner

merged restyled version - #45. thanks for contributing

@nikochiko nikochiko closed this Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants