Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(board): add option to add quick-filters #136

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marstamm
Copy link

Adds the option to save and quickly access frequently used filters on the board.

Filters are stored in localStorage and persisted accross sessions, but not accross accounts/browsers.

Recording 2022-06-17 at 13 59 59

@nikku
Copy link
Owner

nikku commented Jun 19, 2022

Thanks for your contribution.

I've personally thought about a feature like this before, however I dismissed it earlier because Browsers can just bookmark things. How do you see this being better than a simple browser bookmark?

@marstamm
Copy link
Author

marstamm commented Jul 5, 2022

Hi @nikku ,

I think that using Bookmarks is really unintuitive for this feature. Anecdotally, I never considered this possibility before you mentioned it 😅

I think having this as part of the application improves on the UX over Bookmarks:

  • No need to have a Bookmarks bar enabled
  • Only available while on the site - does not take real estate on bookmarks bar/screen on other pages
  • better Indication on how to add them

Overall, I think bookmarks work as a workaround, but do not replace a native feature

@nikku
Copy link
Owner

nikku commented Jul 8, 2022

Makes sense. I'll play around with your PR and may end up with a variation that is a little bit less verbose.


To understand your requirements:

  • Quick filters should be accessible with a single click?
  • How often do you create a quick filter (over using it)? => Is it fine to create it via a keyboard shortcut?

@marstamm
Copy link
Author

marstamm commented Jul 8, 2022

I'll play around with your PR and may end up with a variation that is a little bit less verbose

👍

Quick filters should be accessible with a single click?

I based my implementation of Jira, an in my opinion this works well

How often do you create a quick filter (over using it)?

I will not change the filters often after I created my most-used ones, so I rarely add or remove some. A Keyboard Shortcut or a more hidden button will work as well

@nikku
Copy link
Owner

nikku commented Feb 19, 2023

I had a look into this but was not able to complete it. Will give it another try next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants