Improve performance of find() and findFirst() when passed $nodes is e…

…mpty array
nikic · Oct 7, 2023 · 481fec4 · 481fec4
1 parent 4e27a17
commit 481fec4
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/lib/PhpParser/NodeFinder.php b/lib/PhpParser/NodeFinder.php
@@ -15,6 +15,10 @@ class NodeFinder {
      * @return Node[] Found nodes satisfying the filter callback
      */
     public function find($nodes, callable $filter): array {
+        if ($nodes === []) {
+            return [];
+        }
+
         if (!is_array($nodes)) {
             $nodes = [$nodes];
         }
@@ -52,6 +56,10 @@ public function findInstanceOf($nodes, string $class): array {
      * @return null|Node Found node (or null if none found)
      */
     public function findFirst($nodes, callable $filter): ?Node {
+        if ($nodes === []) {
+            return null;
+        }
+
         if (!is_array($nodes)) {
             $nodes = [$nodes];
         }