Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profile annotator auth issue #255

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix profile annotator auth issue #255

wants to merge 4 commits into from

Conversation

ddjnw1yu
Copy link
Collaborator

No description provided.

@cypress Cypress
Copy link

cypress bot commented Jan 21, 2025 •
edited
Loading

SPARC Vue3 Portal Testing    Run #405

Run Properties:  status check passed Passed #405  •  git commit 14ea39e18d: Add await
Project SPARC Vue3 Portal Testing
Branch Review Fix-profile-annotator-auth-issue
Run status status check passed Passed #405
Run duration 17m 15s
Commit git commit 14ea39e18d: Add await
Committer David J. Yu
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 25
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 176
View all changes introduced in this branch ↗︎

@ddjnw1yu ddjnw1yu requested a review from alan-wu January 21, 2025 23:34
@alan-wu alan-wu marked this pull request as draft January 22, 2025 04:03
@alan-wu
Copy link
Contributor

alan-wu commented Jan 22, 2025

This should not be merged in until the end of the promotion.

@alan-wu alan-wu marked this pull request as ready for review January 23, 2025 03:23
@alan-wu
Copy link
Contributor

alan-wu commented Jan 23, 2025

@egauzens This pull request include changes on the profile page to make sure the user is in the correct workspace (SPARC) before testing for their permission to use the annotation tool on maps. Can you please take a look at this? I would to do some testing on staging and it does not have any impact of the user experience. Thanks.

@alan-wu
Copy link
Contributor

alan-wu commented Jan 23, 2025 •
edited
Loading

@ddjnw1yu Looking at the codes, it will be better to put an await keyword when calling this.fetchInProgressDatasets() to make sure it has finished switching through all the organizations before calling this.fetchAnnotatorAuthentication

@ddjnw1yu
Add await
14ea39e 
Make sure fetchInProgressDatasets is completed before fetchAnnotatorAuthentication.
egauzens
egauzens approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@egauzens egauzens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. There's not really a way to test this locally though so won't be able to verify until it's up on staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egauzens egauzens egauzens approved these changes

@alan-wu alan-wu Awaiting requested review from alan-wu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddjnw1yu @alan-wu @egauzens