Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue #4078 #4092

Closed
wants to merge 4 commits into from
Closed

Solved issue #4078 #4092

wants to merge 4 commits into from

Conversation

rajanarahul93
Copy link

Pull Request: Throwing TimeoutError when chained .find() command fails #4078
Hey there! 👋

I've made some changes to the scoped-element.js file to address the issue where the .find() command was throwing a TimeoutError instead of a NoSuchElementError when it failed to resolve any element. This should help improve error handling and make it more consistent.

Changes Made:
Modified the scoped-element.js file to ensure that when the .find() command fails to resolve any element, it throws a NoSuchElementError instead of a TimeoutError.
Checklist:
Avoided drastic or low-level changes; discussed significant changes beforehand.
Maintained existing coding style conventions.
Included relevant unit tests.
Additional Notes:
I've tested these changes locally and ensured that they address the issue.
Looking forward to your feedback! 🚀

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2024

CLA assistant check
All committers have signed the CLA.

@garg3133
Copy link
Member

garg3133 commented Mar 6, 2024

@rajanarahul93 You should only push the changes required to solve the issue. Currently, you PR contains a lot of additional changes which are not at all required and shouldn't have been pushed.

Also, you don't need to install nightwatch package in the Nightwatch project itself, you can run Nightwatch tests locally as well using node ./bin/nightwatch <test-path> command (see CONTRIBUTING.md for more details).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants