Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix abortOnAssertionFailure issue with waitFor commands #3932

Closed
wants to merge 2 commits into from
Closed

fix abortOnAssertionFailure issue with waitFor commands #3932

wants to merge 2 commits into from

Conversation

gravityvi
Copy link
Member

Changes

  • Don't skip the test cases if abortOnFailure is set to false

Impacts

@github-actions
Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@gravityvi gravityvi marked this pull request as draft October 12, 2023 12:44
@gravityvi gravityvi marked this pull request as ready for review October 12, 2023 13:10
@gravityvi gravityvi marked this pull request as draft October 16, 2023 13:44
@gravityvi
Copy link
Member Author

Closing this PR as this is not relevant now

@gravityvi gravityvi closed this Jan 26, 2024
@gravityvi gravityvi deleted the fixes/3931-consider-abortOnAssertion-flag-in-waitFor-commands branch January 26, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AutomatedTester AutomatedTester AutomatedTester approved these changes

@beatfactor beatfactor Awaiting requested review from beatfactor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

abortOnFailure=false for waitForElementVisible/NotVisible does not seem to prevent failures
2 participants
@gravityvi @AutomatedTester