Fixed build script and dev script for running tests on windows. #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status
|
swrdfish
approved these changes
Aug 8, 2023
… tests on windows
yashPratp983
changed the title
garg3133
reviewed
Aug 8, 2023
garg3133
approved these changes
Aug 8, 2023
swrdfish
approved these changes
Aug 8, 2023
gravityvi
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr modifies build script so that tests can be run on windows and also uses cross-env npm package so that example tests can be run on windows.Cross-env was the best project I could find for the job and as it is used as dev dependency so it won't be a problem.