Fix devicestatus Crash #3989
Closed
Fix devicestatus Crash #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 12, 2018 07:20
|
@jpcunningh this looks similar to @sulkaharo open PR #3751. Note that @jasoncalabrese had some remarks on that PR,see #3751 (comment) . I did not fully understand the code change Jason was suggesting, and Mongo errors are hard to reproduce/test. Can you join that PR and see if the best solution is proposed to be merged to dev? |
|
@PieterGit, you are correct. This is mostly a duplicate. |
|
Merged to dev as #4004 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference gitter discussion at nightscout/cgm-remote-monitor: