-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks email after identity, then returns nil and fixes depreciated init #15
base: master
Are you sure you want to change the base?
Conversation
Also if this pull is accepted I will update it to map them in an identity model too. However I don't need it for my application and am unsure if my pull will be accepted. If it is you can expect more pull requests from me ;) |
Hello Mohammad, |
Yeah I was working it out recently. I'm not so good with generators, need to find a way to copy the migration file. But other then that it's ready. Hopefully next week I'll work it out as my computer is down at the moment. Nice to know someone is using it :D |
Would be nice if this pull request was accepted, it has some nice changes. |
@TheEmpty I forked your repo and when I tried to use it with bundler it gave an error. your changes still work fine, just waned to point the error out. devise_rpx_connectable at /home/gabriel/.bundler/ruby/1.8/devise_rpx_connectable-e475bd5d7129 did not have a valid gemspec. |
This was written before bundler ;) if master supports bundler, just apply my patch instead. |
Checks if the user has an email that matches a user before returning nil. Also removed ruby-debug because it can't run on 1.9. Also removed some of the begin and rescue on a thing or two because then it won't report an error when it's fatal instead of something that should be caught.
Also fixes depreciated /rails/init.rb for /init.rb
Sorry for pulling twice!