1.4.4

nicoduj · Feb 20, 2021 · 5511a82 · 5511a82
1 parent ab23523
commit 5511a82
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,12 @@ You can also use the [PACKAGES](https://github.com/oznu/docker-homebridge#option
 
 All notable changes to this project will be documented in this file.
 
+## 1.4.4
+
+- [NEW] bump dep
+- [FIX] wrnings on homebridge 1.3.X
+-
+
 ## 1.4.3
 
 - [NEW] bump dep

diff --git a/deebotEcovacsAPI.js b/deebotEcovacsAPI.js
@@ -233,6 +233,7 @@ DeebotEcovacsAPI.prototype = {
             'INFO - updating sensor for ' + deebotAccessory.name + ' : %s ',
             isOnError
           );
+
           deebotAccessory.HKMotionService.getCharacteristic(
             Characteristic.MotionDetected
           ).updateValue(isOnError);

diff --git a/index.js b/index.js
@@ -230,24 +230,25 @@ myDeebotEcovacsPlatform.prototype = {
 
         if (!myDeebotEcovacsAccessory) {
           myDeebotEcovacsAccessory = new Accessory(deebotName, uuid);
-          myDeebotEcovacsAccessory.name = deebotName;
-          myDeebotEcovacsAccessory.manufacturer = vacBot.vacuum.company;
-          myDeebotEcovacsAccessory.serialNumber = vacBot.vacuum.did;
-
-          myDeebotEcovacsAccessory
-            .getService(Service.AccessoryInformation)
-            .setCharacteristic(Characteristic.Manufacturer, myDeebotEcovacsAccessory.manufacturer)
-            .setCharacteristic(Characteristic.Model, myDeebotEcovacsAccessory.model)
-            .setCharacteristic(Characteristic.SerialNumber, myDeebotEcovacsAccessory.serialNumber);
+
           this.api.registerPlatformAccessories('homebridge-deebotecovacs', 'DeebotEcovacs', [
             myDeebotEcovacsAccessory,
           ]);
           this.foundAccessories.push(myDeebotEcovacsAccessory);
         }
-
+        myDeebotEcovacsAccessory.name = deebotName;
+        myDeebotEcovacsAccessory.manufacturer = vacBot.vacuum.company;
+        myDeebotEcovacsAccessory.serialNumber = vacBot.vacuum.did;
+        myDeebotEcovacsAccessory.model = vacBot.deviceModel;
         myDeebotEcovacsAccessory.vacBot = vacBot;
         myDeebotEcovacsAccessory.name = deebotName;
 
+        myDeebotEcovacsAccessory
+          .getService(Service.AccessoryInformation)
+          .setCharacteristic(Characteristic.Manufacturer, myDeebotEcovacsAccessory.manufacturer)
+          .setCharacteristic(Characteristic.Model, myDeebotEcovacsAccessory.model)
+          .setCharacteristic(Characteristic.SerialNumber, myDeebotEcovacsAccessory.serialNumber);
+
         let HKBatteryService = myDeebotEcovacsAccessory.getServiceByUUIDAndSubType(
           deebotName,
           'BatteryService' + deebotName
@@ -789,7 +790,7 @@ myDeebotEcovacsPlatform.prototype = {
       .on(
         'get',
         function (callback) {
-          callback(false);
+          callback(null, false);
         }.bind(this)
       )
       .on(
@@ -811,7 +812,7 @@ myDeebotEcovacsPlatform.prototype = {
       .on(
         'get',
         function (callback) {
-          callback(false);
+          callback(null, false);
         }.bind(this)
       )
       .on(
@@ -826,7 +827,7 @@ myDeebotEcovacsPlatform.prototype = {
     service.getCharacteristic(Characteristic.MotionDetected).on(
       'get',
       function (callback) {
-        callback(false);
+        callback(null, false);
       }.bind(this)
     );
   },

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "homebridge-deebotecovacs",
-  "version": "1.4.3",
+  "version": "1.4.4",
   "author": "Nicolas Dujardin",
   "description": "Publish your deebot ecovacs as an homekit accessory",
   "main": "index.js",
@@ -25,7 +25,7 @@
     "homekit"
   ],
   "dependencies": {
-    "ecovacs-deebot": "^0.5.5",
+    "ecovacs-deebot": "^0.5.6",
     "node-machine-id": "^1.1.12"
   },
   "bugs": {