Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional NSError parameters to set, get and remove for debugging #38

Closed
wants to merge 7 commits into from

Conversation

Julioacarrettoni
Copy link

In order to help us find a bug I added this 3 methods so we could extract the NSError while using the keychain and log it on our system not just on NSLog as is happening right now.

  • (BOOL)setObject:(nullable id)object forKey:(nonnull id)key error:(NSError * _Nullable * _Nullable) error;
  • (BOOL)removeObjectForKey:(nonnull id)key error:(NSError * _Nullable * _Nullable) error;
  • (nullable id)objectForKey:(nonnull id)key error:(NSError * _Nullable * _Nullable) error;

The original definition of the methods are still there to maintain backwards compatibility. So the user can still use the library as it was using it and if needed track errors.

@MrNickBarker
Copy link

I expanded on this PR in #44 to return errors also when keychain operations fail instead of just serialization errors.

@Julioacarrettoni
Copy link
Author

I closed the PR as the original repo is no longer maintained and also because we are introducing some changes tailored to our needs I doubt other people would be interested in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants