Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Polish/keep device awake #193

Closed
wants to merge 4 commits into from
Closed

Conversation

yiw008
Copy link
Collaborator

@yiw008 yiw008 commented Jun 9, 2022

Administrative Info

Insert a list of all the issues this Pull Request closes below

Make sure your branch name conforms to: <feature/bug/admin>/description or the PR will not pass

Changes

What changes did you make?

Checklist for Review

  • PR's tests are not brittle (will not break if implementation slightly changes)
  • Test cases have a description as to what they test

Lint Changes

If there are any rules your turned off on the linter, write them below

  • TODO

Reviewers

Please checkout the branch and try to find bugs that may have slipped through. Check for confusing code, excessive anonymous functions ( should be short 2-3 line functions if anonymous ), and peformance of the website. Check for consistency of code style.

@yiw008 yiw008 requested review from AW0723 and mmjiang-ucsd June 9, 2022 10:39
@AW0723
Copy link
Collaborator

AW0723 commented Jun 9, 2022

Can you move the JS to a JS file, maybe App.js instead of using inline JS?

yiw008 added 2 commits June 9, 2022 05:19
Ensure that the signal is false when loading the page
Work on iPhone
@yiw008
Copy link
Collaborator Author

yiw008 commented Jun 9, 2022

Can you move the JS to a JS file, maybe App.js instead of using inline JS?

No, because I cannot import an online js file in App.js. If I copy the code of NoSleep.js in our repo, this will cause styling problems resulting in failing the lint test.

Also, I cannot import whatever NoSleep from NoSleep.js. Actually, I cannot understand the structure of NoSleep.js well.

@mmjiang-ucsd
Copy link
Collaborator

Will close for now unless extensive testing can be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Polish Needed] Device Distraction Needs Polish
3 participants