Namespace the Nix-related things #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspiwack
reviewed
Sep 29, 2023
examples/c-hello-world/project.ncl
Outdated
| buildInputs.gcc = organist.lib.import_nix "nixpkgs#gcc", | ||
| buildInputs.coreutils = organist.lib.import_nix "nixpkgs#coreutils", | ||
| buildInputs.bash = organist.lib.import_nix "nixpkgs#bash", | ||
| buildInputs.gcc = organist.nix.builtins.import_nix "nixpkgs#gcc", |
There was a problem hiding this comment.
This is a lot of boilerplate (it was before too, I must say). Note how the list says “Nix” 3 times! Is this something that we expect to be often part of an Organist project description?
There was a problem hiding this comment.
That's indeed quite wordy for something that's bound to be rather common. Let me re-export that from the toplevel of organist, it should already make it more tractable
thufschmitt
force-pushed
the
move-nix-one-layer-down
branch
2 times, most recently
from
4e2a16c to
b245eb9
Compare
Organist isn't _just_ a Nix framework, so we want to make sure that it is possible to add stuff that's not strictly Nix-related to it, and have it feel first-class. So move most of the Nix-related stuff in its own namespace to clear up some real estate for the rest.
thufschmitt
force-pushed
the
move-nix-one-layer-down
branch
from
b245eb9 to
f70e53b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organist isn't just a Nix framework, so we want to make sure that it
is possible to add stuff that's not strictly Nix-related to it, and have
it feel first-class.
So move most of the Nix-related stuff in its own namespace to clear up
some real estate for the rest.
Yet another step toward #58