Skip to content

Commit

Permalink
Fixes for 1.3.1
Browse files Browse the repository at this point in the history
* [fix] EventContactInboxAssigneeChanged.agent is nullable
* [fix] Fix for compatibility with backend API changes
* [chore] Prepare for 1.3.1 release
  • Loading branch information
pavelreiter authored May 16, 2024
1 parent 02a2542 commit 81dfd72
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 11 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
<a name="unreleased"></a>
## [Unreleased]

## [1.3.1]
### Bug Fixes
- EventContactInboxAssigneeChanged.agent is nullable
- Fix for compatibility with backend API changes

## [1.3.0]
### Bug Fixes
- Set CustomerId type to String
Expand Down Expand Up @@ -193,7 +198,8 @@
- failure
- typing start/end

[Unreleased]: https://github.com/nice-devone/nice-cxone-mobile-sdk-android/compare/1.3.0...HEAD
[Unreleased]: https://github.com/nice-devone/nice-cxone-mobile-sdk-android/compare/1.3.1...HEAD
[1.3.1]: https://github.com/nice-devone/nice-cxone-mobile-sdk-android/compare/1.3.0...1.3.1
[1.3.0]: https://github.com/nice-devone/nice-cxone-mobile-sdk-android/compare/1.2.1...1.3.0
[1.2.1]: https://github.com/nice-devone/nice-cxone-mobile-sdk-android/compare/1.2.1...1.2.0
[1.2.0]: https://github.com/nice-devone/nice-cxone-mobile-sdk-android/compare/1.1.0...1.2.0
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ plugins {
}

group = GROUP
version = "1.3.0" // Fallback version
version = "1.3.1" // Fallback version

allprojects {
group = rootProject.group
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ internal data class ChannelConfiguration(
val preContactForm: PreContactFormModel?,

@SerializedName("caseCustomFields")
val contactCustomFields: List<CustomFieldPolyType>,
val contactCustomFields: List<CustomFieldPolyType>?,

@SerializedName("endUserCustomFields")
val customerCustomFields: List<CustomFieldPolyType>,
val customerCustomFields: List<CustomFieldPolyType>?,
) {
data class Settings(
@SerializedName("hasMultipleThreadsPerEndUser")
Expand All @@ -47,7 +47,7 @@ internal data class ChannelConfiguration(
isProactiveChatEnabled = settings.isProactiveChatEnabled,
isAuthorizationEnabled = isAuthorizationEnabled,
preContactSurvey = preContactForm?.toPreContactSurvey(channelId),
contactCustomFields = contactCustomFields.mapNotNull(FieldDefinitionImpl::invoke).asSequence(),
customerCustomFields = customerCustomFields.mapNotNull(FieldDefinitionImpl::invoke).asSequence(),
contactCustomFields = contactCustomFields.orEmpty().mapNotNull(FieldDefinitionImpl::invoke).asSequence(),
customerCustomFields = customerCustomFields.orEmpty().mapNotNull(FieldDefinitionImpl::invoke).asSequence(),
)
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ internal data class EventContactInboxAssigneeChanged(
val data: Data,
) {

val agent get() = data.inboxAssignee.toAgent()
val agent get() = data.inboxAssignee?.toAgent()
val formerAgent get() = data.previousInboxAssignee?.toAgent()
val case get() = data.case

Expand All @@ -41,7 +41,7 @@ internal data class EventContactInboxAssigneeChanged(
@SerializedName("case")
val case: Contact,
@SerializedName("inboxAssignee")
val inboxAssignee: AgentModel,
val inboxAssignee: AgentModel?,
@SerializedName("previousInboxAssignee")
val previousInboxAssignee: AgentModel?,
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ internal class ChannelsConfigurationTests {

@Test
fun testParsing() {
assertEquals(configuration.contactCustomFields.size, 5)
assertEquals(configuration.customerCustomFields.size, 4)
assertEquals(configuration.contactCustomFields?.size, 5)
assertEquals(configuration.customerCustomFields?.size, 4)
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ You can use any uprivilidged valid token, since the package are public.
Then you can the dependency simply by adding:

```groovy
implementation "com.nice.cxone:chat-sdk-core:1.3.0"
implementation "com.nice.cxone:chat-sdk-core:1.3.1"
```

### Additional information
Expand Down

0 comments on commit 81dfd72

Please sign in to comment.